New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Debug #107

Closed
sujinleeme opened this Issue Feb 24, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@sujinleeme
Member

sujinleeme commented Feb 24, 2018

I hope this book handles not only console.log() but also useful and important parts of the Devtools more.

@rwieruch

This comment has been minimized.

Member

rwieruch commented Feb 24, 2018

Hey @sujinleeme Thank you for your recommendations 👍 Maybe we can discuss them here and see how we can synchronize them in all (translated) books :)

Debugging React with Chrome and React Developer Tools would be a great additional chapter. Maybe in the end of the book? Maybe it can touch Break Points too even though I think it's not necessarily related to React. What do you think?

The redux-logger is discussed in Taming the State in React. Because The Road to learn React doesn't introduce Redux, it wouldn't make sense to show redux-logger.

If someone has time to introduce such a chapter in the English version of the book in the first place, let me know. Otherwise I can do it at some point :)

CC @JimmyLv @GuillaumeUnice @FrankFlow @romerorocha

@romerorocha

This comment has been minimized.

Member

romerorocha commented Jul 7, 2018

Should it be a dedicated chapter7.md file, about the "Debugging" subject, containing chapters like:

Debugging React with Chrome

React Developer Tools

Or, just a chapter in the end of chapter6.md?

I think that debugging is important enough to have it's dedicated section, but I'd be happy to write any of these options.

@rwieruch

This comment has been minimized.

Member

rwieruch commented Jul 7, 2018

I would maybe see it as another section in chapter 4, because that's the chapter where testing and folder structures are explained. What do you think?

@romerorocha

This comment has been minimized.

Member

romerorocha commented Jul 7, 2018

Sounds good! I'll try to get it done and send it to evaluation soon.

@rwieruch

This comment has been minimized.

Member

rwieruch commented Jul 7, 2018

Great 💯

@romerorocha

This comment has been minimized.

Member

romerorocha commented Jul 7, 2018

So, my idea here is to explain the main purpose of React Developer Tools and how it works. Inspecting your true components (instead of raw HTML DOM nodes), props, changing state to see what happens, jumping to related source code and so on.

I agree that using Chrome Dev Tools for debugging the source code, inserting breakpoints and stepping in/over them are not necessarily React related knowledge. So, regarding that, would it be ok if I just mention a tutorial link like https://developers.google.com/web/tools/chrome-devtools/javascript/ in the "Exercises" section?

@rwieruch

This comment has been minimized.

Member

rwieruch commented Jul 7, 2018

I agree with both things. React Developer Tools should be the main topic here. Maybe it is possible to relate a bit to the application which is built up until then in chapter 4. Mentioning Chrome Dev Tools in the exercises makes sense as well.

romerorocha added a commit to romerorocha/the-road-to-learn-react that referenced this issue Jul 10, 2018

romerorocha added a commit to romerorocha/the-road-to-learn-react that referenced this issue Jul 10, 2018

rwieruch added a commit that referenced this issue Jul 10, 2018

Merge pull request #151 from romerorocha/master
Fix issue #107 - How to Debug
@rwieruch

This comment has been minimized.

Member

rwieruch commented Jul 10, 2018

Done by @romerorocha in #151 🎉

@rwieruch rwieruch closed this Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment