New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.3: Add/Remove Lifecycle Methods to "Lifecycle Methods Chapter" #115

Closed
rwieruch opened this Issue Apr 1, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@rwieruch
Member

rwieruch commented Apr 1, 2018

The book has a lifecycle methods chapter which explains in a short paragraph each lifecycle method. Since React 16.3 got released, there are 2 new lifecycle methods:

It would be great to add those with a short explanation to the chapter next to the other lifecycle methods in the listing. On the other side, there are three lifecycle methods that got deprecated and can be removed from the book:

  • componentWillMount
  • componentWillReceiveProps
  • componentWillUpdate

Is there anyone who wants to contribute to the book by opening a PR for this issue? :-)

Heads up for @azat-io @FrankFlow @GuillaumeUnice @JimmyLv @miseeger @romerorocha @sujinleeme as well!

@rwieruch

This comment has been minimized.

Member

rwieruch commented Jun 27, 2018

Someone able to help out with this issue? Maybe it's a good topic for learning about the new lifecycle methods :)

@romerorocha

This comment has been minimized.

Member

romerorocha commented Jun 27, 2018

Sure, I'm on it! :)

romerorocha added a commit to romerorocha/the-road-to-learn-react that referenced this issue Jun 27, 2018

romerorocha added a commit to romerorocha/the-road-to-learn-react that referenced this issue Jun 27, 2018

rwieruch added a commit that referenced this issue Jun 27, 2018

Merge pull request #143 from romerorocha/master
Fix issue #115 - New lifecycle methods
@rwieruch

This comment has been minimized.

Member

rwieruch commented Jun 27, 2018

Fixed by @romerorocha in #143

@rwieruch rwieruch closed this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment