Join GitHub today
GPII-2493: Added file exclusion patterns to .nycrc for generating test coverage report for Windows code #1
While this started as a concern for test/code coverage of the windows implementation of the process reporter components, it ended up as tweaking the
This is a pull request against your GPII-2493 branch, not GPII's master. As such it won't automatically start CI, and I don't know how to make that happen (invite @gpii-bot here, maybe?)
It's based on the
A copy of the report is available from my repository. The last entry is for "
Anyhow, hope that's useful.
OK, I managed to run the report with the settings provided. The negates seem like a reasonable starting point. Here's a screenshot of the overview page.
@the-t-in-rtf I haven't had a lot time to work on this today, but here a few quick questions regarding your last comment.
That screenshot closely matches the one I linked to in my original comment. The main difference is that the urls in my report all start with "root" -- for example: "root/gpii/node_modules/WindowsUtilities" They start with "gpii" in your screen shot. Did you change anything in your run?
The documentation for nyc states:
By "main rule that screens out ./node_modules" do you mean that documented default exclusion? Also, I don't see how I could back out the negated rule for "**/node_modules/*" since there isn't such a rule in the
Meanwhile, I'll put index.js back in, see what it does, and see what else I can tweak.
Yes, I meant the implied exclusion. I missed the minus sign there, that was something you removed, and is why the node_modules content is found in the final report.
I didn't change anything, I ran