Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some error checking to pcap_dump(). #494

Open
wants to merge 1 commit into
base: master
from

Conversation

@shane-kerr
Copy link

shane-kerr commented May 31, 2016

We noticed that pcap files were corrupted after a full disk event. This patch tries to help a bit.

Note that probably it would be better if pcap_dump() returned an error code, rather than being a void function. The best way to transition to that might be to add a new function that returned an error, and had pcap_dump() just call that and throw away the error code, then declare pcap_dump() deprecated in a future version of the ABI and ultimately removing it.

Who thought a function that doesn't return an error code was a good idea? 馃槈

@mcr mcr self-assigned this Apr 30, 2019
@mcr mcr added this to the release-after-next milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.