Add some error checking to pcap_dump(). #494

Open
wants to merge 1 commit into
from

Conversation

1 participant
@shane-kerr

We noticed that pcap files were corrupted after a full disk event. This patch tries to help a bit.

Note that probably it would be better if pcap_dump() returned an error code, rather than being a void function. The best way to transition to that might be to add a new function that returned an error, and had pcap_dump() just call that and throw away the error code, then declare pcap_dump() deprecated in a future version of the ABI and ultimately removing it.

Who thought a function that doesn't return an error code was a good idea? 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment