Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong GPS coordinate impact Map display #3689

Closed
gui84 opened this issue May 26, 2020 · 7 comments
Closed

Wrong GPS coordinate impact Map display #3689

gui84 opened this issue May 26, 2020 · 7 comments
Labels
2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: Maps Data entry Related to data formats (date, GPS...) or input limits & conditions

Comments

@gui84
Copy link
Collaborator

gui84 commented May 26, 2020

These two German boulder problems are located in Africa :
https://www.thecrag.com/climbing/germany/pfaelzerwald/route/963675240
https://www.thecrag.com/climbing/germany/pfaelzerwald/route/3308041791

This affect the whole area
https://www.thecrag.com/climbing/germany/pfaelzerwald/area/963081012/

@gui84 gui84 added the Feature: Localisation Localizations are extra things beyond either translations (eg local grade side effects) label May 26, 2020
@Mdemaillard
Copy link
Collaborator

Mdemaillard commented May 26, 2020

hum, known type of issue. For every node, the system calculates a behind the scene Map Boundary box to display every located elements in map display (drawn areas location AND GPS coordinates).

When a really wrong GPS value is input, it stretches retro-actively the map display of all ancestor nodes in the index. This is really easy to do if forgetting the "-" character for longitude in south hemisphere for example.

Simply deleting the wrong GPS values is not working (and a known bug). Modifying them to a approx value does work, but requires time for the boundary box and map display to be reupdated. It seems an update that increases the BBox is immediate, not one that reduces it.

i have taken the following steps to recover:

  • from the area node, edit location -> hover over map inside the area -> grab approximate GPS values from the dynamic display at the bottom right of the map -> cancel location edit
  • edit the 2 routes and input approximate GPS location, and text to notify that the values are not precise
  • refresh the cache for the area in question (unfortunately doesnt refresh the map component)

@Mdemaillard Mdemaillard added 2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: Maps Data entry Related to data formats (date, GPS...) or input limits & conditions and removed Feature: Localisation Localizations are extra things beyond either translations (eg local grade side effects) labels May 26, 2020
@Mdemaillard Mdemaillard changed the title Wrong localisation Wrong GPS coordinate impact Map display May 26, 2020
@scd
Copy link
Member

scd commented May 26, 2020 via email

@Mdemaillard
Copy link
Collaborator

the bbox & visible map accessible from the specific boulders is now corrected.
the issue affecting the ancestors is not, as there is to my knowledge no manual way to refresh / recalculate / update the affected bbox

@Mdemaillard
Copy link
Collaborator

Mdemaillard commented Jun 9, 2020

also affected
https://www.thecrag.com/climbing/australia/north-shore/area/3338453904
rolling up to australia

rootcause: forgotten "-" sign in Lat. in route https://www.thecrag.com/climbing/australia/north-shore/route/3338481069
corrected now.

@Mdemaillard
Copy link
Collaborator

Mdemaillard commented Jun 9, 2020

Correction of the single route level coordinate now automatically resize all ancestors Bboxes :-) Problem above in Australia solved.

Seems not to work on the german issue.

  • All 3 routes in the area had wrong corrdinates (8 ,0)
  • The wrong coords were then deleted from the route input form. That did NOT update the location value visible on the route index.
  • I input now approximate coords on all 3 routes. The area BBox is not immediately updated, as was the case on the Australian issue.

@Mdemaillard
Copy link
Collaborator

update on the german topic:

  • all routes of all boulders in Kalmit had wrong coordinates displaying at route level, even if not present (maybe erased ?) in the coordinate edit field

  • A single batch edit per boulder, with entry of approximate coordinates in a single route updates the coordinates of all routes in the boulder, visible in route page. (still not impacting the coordinates input in the edit field for all additional routes in the boulder). This also gives the boulder a "partially located" status, and update the map of the specific boulder.

  • After all boulders received that "correction", Kalmit map was still not reseting. A slight edit of Kalmits boundary shape triggered a recalculation of its map display box ; and also updated its ancestors.

-> problem manually solved for Kalmit

@rouletout
Copy link
Contributor

Problem fixed, a script is in place to identify outliers but requires manual fix, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: Maps Data entry Related to data formats (date, GPS...) or input limits & conditions
Projects
None yet
Development

No branches or pull requests

5 participants
@scd @rouletout @gui84 @Mdemaillard and others