From 749483f353ee8035a5b12dca4372768a79c8b139 Mon Sep 17 00:00:00 2001 From: veith Date: Sun, 29 May 2022 13:57:49 +0200 Subject: [PATCH] fix: text alignement in cell renderers Dates (in any format) should ideally be left-aligned inside a data table column. A rule of thumb is: integers should be right aligned, while other types of data should be left aligned. The default alignment for most types of data is left alignment -- this helps make the data easily scannable, readable and comparable. https://ux.stackexchange.com/questions/117685/in-tables-should-date-time-year-in-table-be-left-or-right-aligned#:~:text=Dates%20(in%20any%20format)%20should,data%20should%20be%20left%20aligned. --- src/typerenderer/cell-google-protobuf-timestamp.js | 1 - src/typerenderer/cell-google-type-color.js | 1 - src/typerenderer/cell-google-type-date.js | 1 - src/typerenderer/cell-google-type-timeofday.js | 1 - 4 files changed, 4 deletions(-) diff --git a/src/typerenderer/cell-google-protobuf-timestamp.js b/src/typerenderer/cell-google-protobuf-timestamp.js index 51370cae5..fa17b12be 100644 --- a/src/typerenderer/cell-google-protobuf-timestamp.js +++ b/src/typerenderer/cell-google-protobuf-timestamp.js @@ -31,7 +31,6 @@ class CellGoogleProtobufTimestamp extends LitElement { return css` :host { display: block; - text-align: right; white-space: nowrap; } diff --git a/src/typerenderer/cell-google-type-color.js b/src/typerenderer/cell-google-type-color.js index 03cd83a03..f7bcf5aff 100644 --- a/src/typerenderer/cell-google-type-color.js +++ b/src/typerenderer/cell-google-type-color.js @@ -26,7 +26,6 @@ class CellGoolgeTypeColor extends LitElement { return css` :host { display: block; - text-align: right; } :host([hidden]) { diff --git a/src/typerenderer/cell-google-type-date.js b/src/typerenderer/cell-google-type-date.js index 6d6a26855..6b9383d58 100644 --- a/src/typerenderer/cell-google-type-date.js +++ b/src/typerenderer/cell-google-type-date.js @@ -31,7 +31,6 @@ export class CellGoogleTypeDate extends LitElement { return css` :host { display: block; - text-align: right; white-space: nowrap; } diff --git a/src/typerenderer/cell-google-type-timeofday.js b/src/typerenderer/cell-google-type-timeofday.js index b25560d78..4ab26714b 100644 --- a/src/typerenderer/cell-google-type-timeofday.js +++ b/src/typerenderer/cell-google-type-timeofday.js @@ -31,7 +31,6 @@ class CellGoogleTypeTimeofday extends LitElement { return css` :host { display: block; - text-align: right; white-space: nowrap; }