Display highscores #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtleman270
commented
Oct 19, 2019
|
|
||
| app.listen(port, () => console.log(`Example app listening on port ${port}!`)) | ||
|
|
||
| module.exports = app.listen(port) |
There was a problem hiding this comment.
This is needed so testing is easier
turtleman270
commented
Oct 19, 2019
Comment on lines
+20
to
+27
| it("should fail when not provided a username", (done) => { | ||
| chai.request(app) | ||
| .get('/') | ||
| .end((err, res) => { | ||
| res.should.have.status(404) | ||
| done() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This will most likely need to be changed in the future.
Once we support no entering a username, this test will need to be updated
There was a problem hiding this comment.
I didn't see this right away, would have saved me some troubles. Whoops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional changes:
-displays api output
Testing:
-added tests around the api call
-manually tested and saw the output as expected
Readme:
-updated readme explaining how to build/run this app