{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":204970720,"defaultBranch":"master","name":"bitcoin","ownerLogin":"theStack","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-08-28T15:59:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/91535?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717553277.0","currentOid":""},"activityList":{"items":[{"before":"d113709dc4e68535605d22814ea987b55469bd32","after":"5cf0a1f230389ef37e0ff65de5fc98394f32f60c","ref":"refs/heads/test-fix_keys_to_multisig_for_17+","pushedAt":"2024-06-05T14:21:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: add `createmultisig` P2MS encoding test for all n (1..20)","shortMessageHtmlLink":"test: add <code>createmultisig</code> P2MS encoding test for all n (1..20)"}},{"before":"8801e319d51209fe3a3b06e2aab5f96ceead290d","after":null,"ref":"refs/heads/202406-remove_unused_key_negate","pushedAt":"2024-06-05T02:07:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":null,"after":"8801e319d51209fe3a3b06e2aab5f96ceead290d","ref":"refs/heads/202406-remove_unused_key_negate","pushedAt":"2024-06-03T15:00:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"refactor: remove unused `CKey::Negate` method\n\nThis method was introduced as a pre-requirement for the v2 transport\nprotocol back then (see PR #14047, commit 463921bb), when it was still\nBIP151. With the replacement BIP324, this is not needed anymore, and\nit's also unlikely that any other proposal would need to negate private\nkeys at this abstraction level.\n(If there is really demand, it's trivial to reintroduce the method.)","shortMessageHtmlLink":"refactor: remove unused <code>CKey::Negate</code> method"}},{"before":null,"after":"bf8178b01f5c841b6f480b664bd9682b01c76dac","ref":"refs/heads/202405-contrib-bip352_input_pubkeys_cancelled","pushedAt":"2024-05-31T22:04:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"contrib: add script to submit tx with zero-sum input pubkeys (-> point of infinity)","shortMessageHtmlLink":"contrib: add script to submit tx with zero-sum input pubkeys (-&gt; poin…"}},{"before":"93527b82e70c8e19d7317ce5287b0ee2a0020f1b","after":"39d135e79f3f0c40dfd8fad2c53723d533cd19b4","ref":"refs/heads/202405-test-MiniWallet_target_weight_improvements","pushedAt":"2024-05-30T22:22:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py","shortMessageHtmlLink":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_…"}},{"before":"15b0c483a6bd00ae1c4c7d8fc4b3334b134f92d5","after":"0a89179d62a5b2c5ebc20b806122bb50fc199cba","ref":"refs/heads/add-utxo_to_sqlite-conversion-tool","pushedAt":"2024-05-23T22:39:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: add test for utxo-to-sqlite conversion script","shortMessageHtmlLink":"test: add test for utxo-to-sqlite conversion script"}},{"before":"2be1e86de5c933872894e3cb9b75048722eec708","after":"93527b82e70c8e19d7317ce5287b0ee2a0020f1b","ref":"refs/heads/202405-test-MiniWallet_target_weight_improvements","pushedAt":"2024-05-23T18:17:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py","shortMessageHtmlLink":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_…"}},{"before":"8c7d90b985a9546e775a23081b139f9b27f6fd68","after":"2be1e86de5c933872894e3cb9b75048722eec708","ref":"refs/heads/202405-test-MiniWallet_target_weight_improvements","pushedAt":"2024-05-23T18:14:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py","shortMessageHtmlLink":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_…"}},{"before":null,"after":"8c7d90b985a9546e775a23081b139f9b27f6fd68","ref":"refs/heads/202405-test-MiniWallet_target_weight_improvements","pushedAt":"2024-05-23T17:40:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit.py","shortMessageHtmlLink":"test: MiniWallet: respect fee_rate for target_weight, use in mempool_…"}},{"before":null,"after":"f758e73a943b8e45acac1ab8834305f7f0bfbf14","ref":"refs/heads/pr28531-alt-fill_mempool-fix","pushedAt":"2024-05-22T23:31:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: ensure that `fill_mempool` leaves some room in mempool","shortMessageHtmlLink":"test: ensure that <code>fill_mempool</code> leaves some room in mempool"}},{"before":"361c3b0ad167de8636b1500d4c0176e7241bec4d","after":"ad0a8ffceacfd5ce37826b2882b0e51a14c5a6bf","ref":"refs/heads/complete_bdb-ro_python_parser2","pushedAt":"2024-05-22T09:58:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: compare BDB dumps of test framework parser and wallet tool","shortMessageHtmlLink":"test: compare BDB dumps of test framework parser and wallet tool"}},{"before":"d166e8886c21db074b2f9a490ba6bb10304e3a89","after":"361c3b0ad167de8636b1500d4c0176e7241bec4d","ref":"refs/heads/complete_bdb-ro_python_parser2","pushedAt":"2024-05-21T17:17:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: compare BDB dumps of test framework parser and wallet tool","shortMessageHtmlLink":"test: compare BDB dumps of test framework parser and wallet tool"}},{"before":null,"after":"26034684fa594de861a7467c7905d0f0a11987cd","ref":"refs/heads/pr30072_test_on_master","pushedAt":"2024-05-21T16:40:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"make extended carve out test pass","shortMessageHtmlLink":"make extended carve out test pass"}},{"before":"8950053636cb38ed85fe2d58b53e5d0acb35c390","after":null,"ref":"refs/heads/test-remove_maxorphantx_extra_args","pushedAt":"2024-05-20T08:49:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":"75246eecad99af7aef3333c2d4b4c9e96a148008","after":"8950053636cb38ed85fe2d58b53e5d0acb35c390","ref":"refs/heads/test-remove_maxorphantx_extra_args","pushedAt":"2024-05-17T20:39:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: remove unneeded `-maxorphantx=1000` settings\n\nIt's unclear what the motivation for increasing the orphan pool is, and\nit seems that this not needed at all. None of these tests involve orphan\ntransactions explicitly, and if they would occur occasionally, there is\nno good reason to prefer a value of 1000 over the default of 100 (see\nDEFAULT_MAX_ORPHAN_TRANSACTIONS).","shortMessageHtmlLink":"test: remove unneeded <code>-maxorphantx=1000</code> settings"}},{"before":null,"after":"75246eecad99af7aef3333c2d4b4c9e96a148008","ref":"refs/heads/test-remove_maxorphantx_extra_args","pushedAt":"2024-05-17T20:33:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: remove unneeded `-maxorphantx=1000` settings\n\nIt's unclear what the motivation for increasing the orphan pool is, and\nit seems that this not needed at all. None of these tests involve orphan\ntransactions explicitly, and if they would occur occasionally, there is\nno good reason to prefer a value of 1000 over the default of 100 (see\nDEFAULT_MAX_ORPHAN_TRANSACTIONS).","shortMessageHtmlLink":"test: remove unneeded <code>-maxorphantx=1000</code> settings"}},{"before":null,"after":"d166e8886c21db074b2f9a490ba6bb10304e3a89","ref":"refs/heads/complete_bdb-ro_python_parser2","pushedAt":"2024-05-16T17:12:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: compare BDB dumps of test framework parser and wallet tool","shortMessageHtmlLink":"test: compare BDB dumps of test framework parser and wallet tool"}},{"before":"12d82817bf32396b58c8c65645012def606680b6","after":null,"ref":"refs/heads/202405-refactor-simplify-FormatSubVersion","pushedAt":"2024-05-15T06:49:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":"91b9af8109b3fd94dd63ef50a3049a8e24ec12e7","after":"12d82817bf32396b58c8c65645012def606680b6","ref":"refs/heads/202405-refactor-simplify-FormatSubVersion","pushedAt":"2024-05-13T21:32:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"refactor: simplify `FormatSubVersion` using strprintf/Join\n\nRather than using std::ostringstream and manually joining the\ncomments, use strprintf and our own `Join` helper.","shortMessageHtmlLink":"refactor: simplify <code>FormatSubVersion</code> using strprintf/Join"}},{"before":null,"after":"91b9af8109b3fd94dd63ef50a3049a8e24ec12e7","ref":"refs/heads/202405-refactor-simplify-FormatSubVersion","pushedAt":"2024-05-13T21:27:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"refactor: simplify `FormatSubVersion` using strprintf/Join\n\nRather than using std::ostringstream and manually joining the\ncomments, use strprintf and our own `Join` helper.","shortMessageHtmlLink":"refactor: simplify <code>FormatSubVersion</code> using strprintf/Join"}},{"before":"3a3ccf00f0bb6b6450dcf859982cdb40bb06f475","after":"fe92c15f0c44d1405b9048306736bd0eae868506","ref":"refs/heads/202311-add_SignTransaction_benchmark","pushedAt":"2024-05-12T16:03:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"script/sign: avoid duplicated signature verification after signing\n\n`ProduceSignature` already calls `VerifyScript` internally as last step in\norder to check whether the signature data is complete. If and only if that is\nthe case, the `complete` field of the `SignatureData` is set accordingly and\nthere is no need then to verify the script after again, as we already know that\nit would succeed.\n\nThis leads to a rough ~20% speed-up for `SignTransaction` for single-input\nECDSA or Taproot inputs, according to the `SignTransaction{ECDSA,Taproot}`\nbenchmarks.","shortMessageHtmlLink":"script/sign: avoid duplicated signature verification after signing"}},{"before":"e4abac2fce4af98108d899bc0480d066e5da7754","after":"57eb59024b4d5b776ddb08736a81585c2ea0e734","ref":"refs/heads/202405-MiniWallet-fix_script_path_spend_missing_sign_bit","pushedAt":"2024-05-11T16:45:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: fix MiniWallet script-path spend (missing parity bit in leaf version)\n\nThis commit fixes a dormant bug in MiniWallet that exists since\nsupport for P2TR was initially added in #23371 (see commit\n041abfebe49ae5e3e882c00cc5caea1365a27a49).\n\nIn the course of spending the output, the leaf version byte of the\ncontrol block in the witness stack doesn't set the parity bit, i.e.\nwe were so far just lucky that the used combinations of relevant\ndata (internal pubkey, leaf script / version) didn't result in a\ntweaked pubkey with odd y-parity. If that was the case, we'd get the\nfollowing validation error:\n\n`mandatory-script-verify-flag-failed (Witness program hash mismatch) (-26)`\n\nSince MiniWallets can now optionally be tagged (#29939), resulting\nin different internal pubkeys, the issue is more prevalent now.\nFix it by passing the parity bit, as specified in BIP341.","shortMessageHtmlLink":"test: fix MiniWallet script-path spend (missing parity bit in leaf ve…"}},{"before":"dd8fa861939d5b8bdd844ad7cab015d08533a91a","after":null,"ref":"refs/heads/202404-test-support_MiniWallet_tags","pushedAt":"2024-05-11T06:04:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":"e529e928ff5dfeb7a4809a5e34451e20e102a0ca","after":"e4abac2fce4af98108d899bc0480d066e5da7754","ref":"refs/heads/202405-MiniWallet-fix_script_path_spend_missing_sign_bit","pushedAt":"2024-05-09T22:48:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: fix MiniWallet script-path spend (missing parity bit in leaf version)\n\nThis commit fixes a dormant bug in MiniWallet that exists since\nsupport for P2TR was initially added in #23371 (see commit\n041abfebe49ae5e3e882c00cc5caea1365a27a49).\n\nIn the course of spending the output, the leaf version byte of the\ncontrol block in the witness stack doesn't set the parity bit, i.e.\nwe were so far just lucky that the used combinations of relevant\ndata (internal pubkey, leaf script / version) didn't result in a\ntweaked pubkey with odd y-parity. If that was the case, we'd get the\nfollowing validation error:\n\n`mandatory-script-verify-flag-failed (Witness program hash mismatch) (-26)`\n\nSince MiniWallets can now optionally be tagged (#29939), resulting\nin different internal pubkeys, the issue is more prevalent now.\nFix it by passing the parity bit, as specified in BIP341.","shortMessageHtmlLink":"test: fix MiniWallet script-path spend (missing parity bit in leaf ve…"}},{"before":null,"after":"e529e928ff5dfeb7a4809a5e34451e20e102a0ca","ref":"refs/heads/202405-MiniWallet-fix_script_path_spend_missing_sign_bit","pushedAt":"2024-05-09T17:44:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: fix MiniWallet script-path spend (missing parity bit in leaf version)\n\nThis commit fixes a dormant bug in MiniWallet that exists since\nsupport for P2TR was initially added in #23371 (see commit\n041abfebe49ae5e3e882c00cc5caea1365a27a49).\n\nIn the course of spending the output, the leaf version byte of the\ncontrol block in the witness stack doesn't set the parity bit, i.e.\nwe were so far just lucky that the used combinations of relevant\ndata (internal pubkey, leaf script / version) didn't result in a\ntweaked pubkey with odd y-parity. If that was the case, we'd get the\nfollowing validation error:\n\n`mandatory-script-verify-flag-failed (Witness program hash mismatch) (-26)`\n\nSince MiniWallets can now optionally be tagged (#29939), resulting\nin different internal pubkeys, the issue is more prevalent now.\nFix it by passing the parity bit, as specified in BIP341.","shortMessageHtmlLink":"test: fix MiniWallet script-path spend (missing parity bit in leaf ve…"}},{"before":"98570fe29bb08d7edc48011aa6b9731c6ab4ed2e","after":null,"ref":"refs/heads/202308-rpc-consistent_legacy_pubkey_parsing_errors","pushedAt":"2024-05-08T22:57:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":"8b52e7f628304e83b0e36fd97e617de0f71c5a62","after":null,"ref":"refs/heads/202404-further-subprocess-removals","pushedAt":"2024-05-08T14:22:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"}},{"before":"176c8cceb3718ffc230642a434188604f705a4e4","after":"dd8fa861939d5b8bdd844ad7cab015d08533a91a","ref":"refs/heads/202404-test-support_MiniWallet_tags","pushedAt":"2024-05-05T10:37:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: use tagged ephemeral MiniWallet instance in fill_mempool","shortMessageHtmlLink":"test: use tagged ephemeral MiniWallet instance in fill_mempool"}},{"before":"45bf7dba025b27916f5c4c4a385340006b62cd38","after":"176c8cceb3718ffc230642a434188604f705a4e4","ref":"refs/heads/202404-test-support_MiniWallet_tags","pushedAt":"2024-05-05T10:22:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: use tagged ephemeral MiniWallet instance in fill_mempool","shortMessageHtmlLink":"test: use tagged ephemeral MiniWallet instance in fill_mempool"}},{"before":null,"after":"45bf7dba025b27916f5c4c4a385340006b62cd38","ref":"refs/heads/202404-test-support_MiniWallet_tags_backup","pushedAt":"2024-05-05T09:41:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"theStack","name":"Sebastian Falbesoner","path":"/theStack","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91535?s=80&v=4"},"commit":{"message":"test: rescan user's MiniWallet UTXOs at the end of fill_mempool","shortMessageHtmlLink":"test: rescan user's MiniWallet UTXOs at the end of fill_mempool"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXTdrKgA","startCursor":null,"endCursor":null}},"title":"Activity · theStack/bitcoin"}