New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - implement support for Windows #6

Open
theWebalyst opened this Issue Sep 21, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@theWebalyst
Copy link
Owner

theWebalyst commented Sep 21, 2018

Hopefully SAFE FUSE needs only minor code changes along with packaging and an update of the README.md for it to work on Windows (also Mac if anyone is interested!).

A couple of notes about getting SAFE FUSE working on Windows:

  1. One code change I can think of is that we will need to translate incoming paths from Windows backslash to forward slash. I think this can all be handled with a check in each src/fuse-operations implementation file, something like this:
    if (path.sep !=== '/') {
      let expression = '/\\' + path.sep + '/g'
      itemPath = itemPath.replace(expression, '/')
    }

There may be other places where I messed up with path separators because I wasn't thinking straight about it at the start, so look out! On the other hand all the Safenetworkjs code assumes '/' which is fine because it only knows about SAFE so it may all be fine 😄

  1. The FUSE library we use relies on Dokany to work on Windows, so end user instructions for Dokany need to be added into the README.md instructions. I think just sending people to the Dokany page is not that helpful as it isn't really written for end users. I see their releases page offers several options, so I suggest evaluating these and provide links and instructions in SAFE FUSE README.md. It also looks like they offer something we could re-distribute, so perhaps the easiest is to package that in the zip and then have them run it before trying to mount-safe?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment