Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint and fix issues #16

Closed
eduardb opened this issue Oct 9, 2019 · 7 comments
Closed

Add lint and fix issues #16

eduardb opened this issue Oct 9, 2019 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@eduardb
Copy link
Collaborator

eduardb commented Oct 9, 2019

What the title says.

@eduardb eduardb added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 9, 2019
@VivekSingh777
Copy link

VivekSingh777 commented Oct 9, 2019

Can I grab this issue?
@eduardb

@eduardb
Copy link
Collaborator Author

eduardb commented Oct 9, 2019

Hi @VivekSingh777! Yes, please, go for it :)

@eduardb
Copy link
Collaborator Author

eduardb commented Oct 14, 2019

Hi @VivekSingh777! Do you have any updates on this? Take also into consideration breaking it down in several iterations, doing everything in one go might be too much of an effort.

@VivekSingh777
Copy link

Sorry I don't required resources to install this on my local. Can u reassign to some one else.

@VivekSingh777 VivekSingh777 removed their assignment Oct 14, 2019
@eduardb
Copy link
Collaborator Author

eduardb commented Oct 15, 2019

Sure, no problem. Thanks for showing your interest in the first place :)

@subbramanil
Copy link
Contributor

@eduardb Let me take a stab at it.

Bit confused about 'Add lint'.

From Android Studio, I see the below results.

Lint Results

I can't promise that I can fix everything, but I'm confident about most of it.

Let me know

@eduardb
Copy link
Collaborator Author

eduardb commented Oct 20, 2019

Hi @subbramanil! Sorry for getting back this late to you.
Yes, you are right, Lint is already running, that was a mistake from my part. Maybe what else could be done would be making the build fail if new lint errors are added.
Feel free to fix as much as you can, and then just create a baseline for the rest. We like to iterate :)
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants