hotfix: Addresses Lint Warnings - #20
Merged
Merged
Conversation
- Cleans up unused import statements - Applies appropriate scope qualifiers (i.e., private) for variables & functions - Moves hard-coded strings to String.xml & consts as required - Cleans up Regular expressions by removing unnecessary character escapes **Note:** 1. Almost all of the fixes were applied automatically through Android Studio's Auto-Suggestions which made sense & appropriate. None of the changes should affect the functionality of the app. No files were removed, although there were unused files & references. 2. Reports character escapes that are replaceable with the unescaped character without a change in meaning. Note that inside the square brackets of a character class, many escapes are unnecessary that would be necessary outside of a character class. For example the regex [\.] is identical to [.] 3. None of the changes should affect any functionality. But in case of any doubt, any change can be removed, analyzed & applied on another iteration.
eduardb
requested changes
Oct 25, 2019
eduardb
left a comment
eduardb
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution, @subbramanil! Your changes look good, but I think that there is a small change in behaviour in activity_new_health_facility.xml, could you please have a look into the comments? Cheers!
Contributor
Author
|
Updated the PR with the fixes. |
eduardb
approved these changes
Oct 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
Reference: #16