Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new translations / Update old translations! #130

Open
thebigsmileXD opened this issue Oct 3, 2019 · 11 comments

Comments

@thebigsmileXD
Copy link
Owner

commented Oct 3, 2019

πŸ“ New Translations

I want to introduce new translations and update current ones. Interested in "Hacktoberfest"? Here you can get started!

Any language is appreciated!

❓ How to contribute

  • switch to the TRANSLATIONS branch (current default branch) https://github.com/thebigsmileXD/MagicWE2/tree/translations - edits on master or other branches will be tagged invalid
  • Create a fork
  • Edit or add the corresponding file in /resources/lang, based on the english translation found here
  • If you modify an already existing language file, please make sure to remove entries that do not exist on eng.ini, and add those that are missing
  • Create a pull request and reference this issue (referencing is optional)
  • Pull Requests will be merged shortly before 30th October to leave you some time to correct translations (This does not influence Hacktoberfest, they are still counted if not merged)

Thanks to everyone who contributes!

πŸ—’ Notes & Guidelines

  • This is a Minecraft-related world editor, so some terms are special, i.e. "flood" has a similar meaning to the "Paint.exe paint bucket", and "Wand" is a region selection tool (See #64, there are several examples and explainations) (Please also check comments in this issue for some other special entries)
  • The translation files must be named after the iso639-2 3-letter format (See https://www.loc.gov/standards/iso639-2/php/English_list.php)
  • The language.name key must be the "English Name of Language" entry from that website
  • Translation strings must be enclosed by " "
  • Readme may not be translated (too difficult to keep it updated)

πŸ’œ As always, enjoy Hacktoberfest!

Have fun and good luck with your πŸ‘•, Dan ❀

@dingyifei

This comment has been minimized.

Copy link

commented Oct 4, 2019

Hi, I found the iso639-2 doesn't specify differences between Simplified Chinese and Traditional Chinese. Traditional Chinese is already taking the zho.ini file, should I use chi.ini or zh-s and rename zho.ini to zh-t.ini based on Wikipedia?
图片

@ooguz

This comment has been minimized.

Copy link

commented Oct 4, 2019

Turkish translation has come. #135

@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

You'll probably want to use chs then, at least that's how this project handles it: https://github.com/pmmp/PocketMine-Language/blob/master/README.md

@Aericio Aericio closed this Oct 4, 2019
@Aericio Aericio reopened this Oct 4, 2019
@Aericio

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2019

My bad.

@msdeibel

This comment has been minimized.

Copy link

commented Oct 4, 2019

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

msdeibel pushed a commit to msdeibel/MagicWE2 that referenced this issue Oct 4, 2019
This translation uses the informal "you" (du).
@thebigsmileXD

This comment has been minimized.

Copy link
Owner Author

commented Oct 5, 2019

Note: i changed the translations branch to be default to simplify it for the contributors, currently alot of people edited on master - please make sure to commit into translations!

Thanks so far!

@thebigsmileXD

This comment has been minimized.

Copy link
Owner Author

commented Oct 5, 2019

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

I updated german myself personally, though i will change them to be all lowercase, thanks for the reminder

@thebigsmileXD

This comment has been minimized.

Copy link
Owner Author

commented Oct 5, 2019

@thebigsmileXD

This comment has been minimized.

Copy link
Owner Author

commented Oct 9, 2019

We had some discussions about some translation entries, so here is a heads-up on some things we have noticed:

  • Please make sure that {%0} is properly kept and do not contain spaces, those are places were strings are inserted
  • Make sure //togglewand and //toggledebug and similar entries with foregoing slashes are kept - those are commands
Translation key Explaination Reference
tool.debug.lore.2 Meta values are a Minecraft specific term #137 (comment)
ui.brush.options.flags Flags means "adding options" #150 (comment)
ui.brush.options.flags Biomes are a Minecraft specific term https://minecraft.gamepedia.com/Biome
ui.brush.options.flags Chunks are a Minecraft specific term https://minecraft.gamepedia.com/Chunk
@GEveloper

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2019

@thebigsmileXD
Is the value of ui.flood.options.label.infoapply (line 92) correct ? Does not need to escape quotes like in command.brushname.set (line 36) ?

@thebigsmileXD

This comment has been minimized.

Copy link
Owner Author

commented Oct 17, 2019

@GEveloper it appears to work anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.