Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese Translation #134

Open
wants to merge 6 commits into
base: translations
from

Conversation

@dingyifei
Copy link

commented Oct 4, 2019

#130
https://en.wikipedia.org/wiki/Template:ISO_639_name

Maybe it should be renamed to zh-s.ini or zhs.ini?

dingyifei added 2 commits Oct 4, 2019
temporarely name it `chi.ini` since `zho.ini` is taken by Traditional Chinese
chi.ini -> zhs.ini (Simplified Chinese)
zho.ini -> zht.ini (Traditional Chinese)
@dingyifei

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

I renamed zho.ini and chi.ini to zht.ini and zhs.ini

@dingyifei

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

I see #138 had changed zho.ini, should I revert my 7db2ece commit?

@Aericio

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2019

No, since you're first we'll accept yours and reject his.

@thebigsmileXD

This comment has been minimized.

Copy link
Owner

commented Oct 5, 2019

I guess it doesn't matter that much - it is just a guideline, but the filename is never shown anywhere else than github, neither exposed in the plugin - what matters is the language.name string :P
The iso639-2 format was just so people can easier recognize the files they have to edit, since we had duplicated languages last year with different file names

@@ -1,5 +1,5 @@
; Updated time : 26th 07 2017
language.name = "Chinese"
language.name = "Traditional Chinese"

This comment has been minimized.

Copy link
@thebigsmileXD

thebigsmileXD Oct 5, 2019

Owner

Good point to change it 👍

@thebigsmileXD thebigsmileXD added this to the 10.0.0 milestone Oct 9, 2019
dingyifei added 2 commits Oct 12, 2019
This reverts commit 7db2ece.
@dingyifei

This comment has been minimized.

Copy link
Author

commented Oct 12, 2019

I revert the cht.ini and chs.ini back to zho.ini and chi.ini based on user4086's comment on that StackExchange question

@@ -1,5 +1,5 @@
; Updated time : 26th 07 2017
language.name = "Traditional Chinese"

This comment has been minimized.

Copy link
@thebigsmileXD

thebigsmileXD Oct 14, 2019

Owner

wasn't this changed to remove confusion?

This comment has been minimized.

Copy link
@dingyifei

dingyifei Oct 16, 2019

Author

I revert the change, then changed zho.ini to "Traditional Chinese".... right now the "zho.ini" should be Traditional Chinese and the "chi.ini" is "Simplified Chinese". I just realized I did the opposite of what the post said...

@dingyifei

This comment has been minimized.

Copy link
Author

commented Oct 16, 2019

I switch the zho.ini and chi.ini, so now Simplified Chinese = "zho.ini" and Traditional Chinese = "chi.ini" as the post said.

I'll bet that the designer takes "zho" to mean simplified Chinese and "chi" to mean traditional Chinese. Reason: "zhong" is a mainland-style "Pinyin" transcription, and in regions where traditional Chinese is used (such as Taiwan and Hong Kong), "Pinyin" is not the default phonetic system. – user4086

@thebigsmileXD

This comment has been minimized.

Copy link
Owner

commented Oct 16, 2019

Ok cool 👍 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.