Feature/reverse arrows #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebjorn
requested changes
Jan 23, 2019
Owner
thebjorn
left a comment
thebjorn
left a comment
There was a problem hiding this comment.
Thank you very much for the PR. I've made a couple of suggestions. If you can fix those then I'll merge it immediately.
pydeps/cli.py
Outdated
| p.add_argument('--show-deps', action='store_true', help="show output of dependency analysis") | ||
| p.add_argument('--show-raw-deps', action='store_true', help="show output of dependency analysis before removing skips") | ||
| p.add_argument('--show-dot', action='store_true', help="show output of dot conversion") | ||
| p.add_argument('--reverse', action='store_true', help="draw arrows in direction of dependency") |
Owner
There was a problem hiding this comment.
Suggested change
| p.add_argument('--reverse', action='store_true', help="draw arrows in direction of dependency") | |
| p.add_argument('--reverse', action='store_true', help="draw arrows to (instead of from) imported modules") |
Author
There was a problem hiding this comment.
I changed it and added to the readme
pydeps/render_context.py
Outdated
| self.name = kw.get('name', 'G') | ||
| self.fillcolor = kw.get('fillcolor', '#ffffff') | ||
| self.fontcolor = kw.get('fontcolor', '#000000') | ||
| self.rankdir = kw.get('rankdir', 'TB' if not self.reverse else 'BT') |
Owner
There was a problem hiding this comment.
I appreciate that you're trying to kkep the non-reverse case the default, but this reads better if you reverse the logic
Suggested change
| self.rankdir = kw.get('rankdir', 'TB' if not self.reverse else 'BT') | |
| self.rankdir = kw.get('rankdir', 'BT' if self.reverse else 'TB') |
Author
There was a problem hiding this comment.
I also changed this, in addition there is now also a test for it.
thebjorn
approved these changes
Jan 23, 2019
Owner
|
Thanks for the PR. It's now released on PyPI as version 1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse arrow directions as discussed in #8