Add support for display envvars #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmmm, wouldn't this be a great time to drop 2.7 support? 😀 |
Owner
|
Nope, still a horrible time to drop 2.7 support :-( |
thebjorn
reviewed
Jul 31, 2020
pydeps/pydeps.py
Outdated
| try: | ||
| svg = dot.call_graphviz_dot(dotsrc, fmt) | ||
| except OSError as cause: | ||
| raise RuntimeError("While rendering {!r}: {}".format(output, cause)) from cause |
Owner
There was a problem hiding this comment.
I wish... but I'm still on 2.7, so I'm afraid this is a no-go :-(
Owner
|
I like your other changes though... |
Contributor
Author
|
I'll remove the from clauses, then it should work. |
Contributor
Author
|
Giving up. I have no Py2 on this machine. |
Owner
|
Thanks for all your effort! |
Owner
|
v1.9.7 is out on PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks both the PYDEPS_DISPLAY and BROWSER envvars to change the default image file opener.
Also: Extended OS error handling when calling dot, graphviz, and the viewer