From eae688607e141fda5c55342d6c22dd6a3d0d7085 Mon Sep 17 00:00:00 2001 From: kendal Date: Fri, 29 Mar 2024 11:25:42 -0700 Subject: [PATCH 1/2] Enable C++ standard exception handling for windows build --- .github/workflows/bcny-firebase.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/bcny-firebase.yml b/.github/workflows/bcny-firebase.yml index 5e3b3a8413..c101b134a8 100644 --- a/.github/workflows/bcny-firebase.yml +++ b/.github/workflows/bcny-firebase.yml @@ -76,6 +76,8 @@ jobs: -D FIREBASE_INCLUDE_FIRESTORE=YES ` -D FIREBASE_USE_BORINGSSL=YES ` -D MSVC_RUNTIME_LIBRARY_STATIC=NO ` + -D CMAKE_C_FLAGS="/EHsc" ` + -D CMAKE_CXX_FLAGS="/EHsc" ` -D CMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded ` -D FIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=${{ steps.python.outputs.python-path }} ` -D FLATBUFFERS_FLATC_EXECUTABLE=${{ github.workspace }}/BinaryCache/flatbuffers/Release/flatc.exe From 447e4068d75fc2ad43c316da71dd67dde2fb4265 Mon Sep 17 00:00:00 2001 From: kendal Date: Fri, 29 Mar 2024 13:49:14 -0700 Subject: [PATCH 2/2] Disable exception handling altogether --- .github/workflows/bcny-firebase.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bcny-firebase.yml b/.github/workflows/bcny-firebase.yml index c101b134a8..4cfad00789 100644 --- a/.github/workflows/bcny-firebase.yml +++ b/.github/workflows/bcny-firebase.yml @@ -76,8 +76,8 @@ jobs: -D FIREBASE_INCLUDE_FIRESTORE=YES ` -D FIREBASE_USE_BORINGSSL=YES ` -D MSVC_RUNTIME_LIBRARY_STATIC=NO ` - -D CMAKE_C_FLAGS="/EHsc" ` - -D CMAKE_CXX_FLAGS="/EHsc" ` + -D CMAKE_C_FLAGS="/D_HAS_EXCEPTIONS=0 /EHsc-"` + -D CMAKE_CXX_FLAGS="/D_HAS_EXCEPTIONS=0 /EHsc-" ` -D CMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded ` -D FIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=${{ steps.python.outputs.python-path }} ` -D FLATBUFFERS_FLATC_EXECUTABLE=${{ github.workspace }}/BinaryCache/flatbuffers/Release/flatc.exe