From c7a667c8cd007f52ce36497b01b511988e02132e Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Fri, 30 Aug 2024 17:24:38 -0700 Subject: [PATCH 1/2] Copy over headers we use for firebase for the android distribution --- .github/workflows/bcny-firebase.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/bcny-firebase.yml b/.github/workflows/bcny-firebase.yml index 82bb71fed3..09d79ffc8c 100644 --- a/.github/workflows/bcny-firebase.yml +++ b/.github/workflows/bcny-firebase.yml @@ -475,6 +475,29 @@ jobs: cp "$file" "$destination_dir" echo "Copied: $file" done < <(find $source -type f -name "*.a") + echo "Copying header files ..." + header_destination_dir=${{ github.workspace }}/BuildRoot/Library/firebase/usr/include/firebase + firebase_dir=${{ github.workspace }}/SourceCache/firebase-cpp-sdk + mkdir -p $header_destination_dir + cp ${firebase_dir}/app/src/include/firebase/app.h ${header_destination_dir} + cp ${firebase_dir}/app/src/include/firebase/future.h ${header_destination_dir} + cp ${firebase_dir}/app/src/include/firebase/log.h ${header_destination_dir} + cp ${firebase_dir}/app/src/include/firebase/util.h ${header_destination_dir} + cp ${firebase_dir}/app/src/include/firebase/variant.h ${header_destination_dir} + mkdir -p $header_destination_dir/internal + cp ${firebase_dir}/app/src/include/firebase/internal/*.h ${header_destination_dir}/internal/ + cp ${firebase_dir}/auth/src/include/firebase/auth.h ${header_destination_dir} + mkdir -p $header_destination_dir/auth + cp ${firebase_dir}/auth/src/include/firebase/auth/*.h ${header_destination_dir}/auth/ + cp ${firebase_dir}/firestore/src/include/firebase/firestore.h ${header_destination_dir} + mkdir -p $header_destination_dir/firestore + cp ${firebase_dir}/firestore/src/include/firebase/firestore/*.h ${header_destination_dir}/firestore/ + cp ${firebase_dir}/functions/src/include/firebase/functions.h ${header_destination_dir} + mkdir -p $header_destination_dir/functions + cp ${firebase_dir}/functions/src/include/firebase/functions/*.h ${header_destination_dir}/functions/ + cp ${firebase_dir}/storage/src/include/firebase/storage.h ${header_destination_dir} + mkdir -p $header_destination_dir/storage + cp ${firebase_dir}/storage/src/include/firebase/storage/*.h ${header_destination_dir}/storage/ - uses: actions/upload-artifact@v3 with: From a7a0bb3014b4d33bacb40c57add0ad94771e97ef Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Tue, 3 Sep 2024 10:00:33 -0700 Subject: [PATCH 2/2] update the install step for headers for review comment --- .github/workflows/bcny-firebase.yml | 53 ++++++++++++++++++----------- 1 file changed, 33 insertions(+), 20 deletions(-) diff --git a/.github/workflows/bcny-firebase.yml b/.github/workflows/bcny-firebase.yml index 09d79ffc8c..f5490183df 100644 --- a/.github/workflows/bcny-firebase.yml +++ b/.github/workflows/bcny-firebase.yml @@ -478,26 +478,39 @@ jobs: echo "Copying header files ..." header_destination_dir=${{ github.workspace }}/BuildRoot/Library/firebase/usr/include/firebase firebase_dir=${{ github.workspace }}/SourceCache/firebase-cpp-sdk - mkdir -p $header_destination_dir - cp ${firebase_dir}/app/src/include/firebase/app.h ${header_destination_dir} - cp ${firebase_dir}/app/src/include/firebase/future.h ${header_destination_dir} - cp ${firebase_dir}/app/src/include/firebase/log.h ${header_destination_dir} - cp ${firebase_dir}/app/src/include/firebase/util.h ${header_destination_dir} - cp ${firebase_dir}/app/src/include/firebase/variant.h ${header_destination_dir} - mkdir -p $header_destination_dir/internal - cp ${firebase_dir}/app/src/include/firebase/internal/*.h ${header_destination_dir}/internal/ - cp ${firebase_dir}/auth/src/include/firebase/auth.h ${header_destination_dir} - mkdir -p $header_destination_dir/auth - cp ${firebase_dir}/auth/src/include/firebase/auth/*.h ${header_destination_dir}/auth/ - cp ${firebase_dir}/firestore/src/include/firebase/firestore.h ${header_destination_dir} - mkdir -p $header_destination_dir/firestore - cp ${firebase_dir}/firestore/src/include/firebase/firestore/*.h ${header_destination_dir}/firestore/ - cp ${firebase_dir}/functions/src/include/firebase/functions.h ${header_destination_dir} - mkdir -p $header_destination_dir/functions - cp ${firebase_dir}/functions/src/include/firebase/functions/*.h ${header_destination_dir}/functions/ - cp ${firebase_dir}/storage/src/include/firebase/storage.h ${header_destination_dir} - mkdir -p $header_destination_dir/storage - cp ${firebase_dir}/storage/src/include/firebase/storage/*.h ${header_destination_dir}/storage/ + mkdir -p $header_destination_dir \ + $header_destination_dir/internal \ + $header_destination_dir/auth \ + $header_destination_dir/firestore \ + $header_destination_dir/functions \ + $header_destination_dir/storage + for header in ${firebase_dir}/app/src/include/firebase/app.h \ + ${firebase_dir}/app/src/include/firebase/future.h \ + ${firebase_dir}/app/src/include/firebase/log.h \ + ${firebase_dir}/app/src/include/firebase/util.h \ + ${firebase_dir}/app/src/include/firebase/variant.h \ + ${firebase_dir}/auth/src/include/firebase/auth.h \ + ${firebase_dir}/firestore/src/include/firebase/firestore.h \ + ${firebase_dir}/functions/src/include/firebase/functions.h \ + ${firebase_dir}/storage/src/include/firebase/storage.h \ + ; do + cp $header ${header_destination_dir} + done + for header in ${firebase_dir}/app/src/include/firebase/internal/*.h; do + cp $header ${header_destination_dir}/internal/ + done + for header in ${firebase_dir}/auth/src/include/firebase/auth/*.h; do + cp $header ${header_destination_dir}/auth/ + done + for header in ${firebase_dir}/firestore/src/include/firebase/firestore/*.h; do + cp $header ${header_destination_dir}/firestore/ + done + for header in ${firebase_dir}/functions/src/include/firebase/functions/*.h; do + cp $header ${header_destination_dir}/functions/ + done + for header in ${firebase_dir}/storage/src/include/firebase/storage/*.h; do + cp $header ${header_destination_dir}/storage/ + done - uses: actions/upload-artifact@v3 with: