Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove unused mark_for_deletion functionality #128
Found some unused functionality while spelunking the codebase. Of course this might be used with tools you have not published. Below is what I wrote in the first commit:
Thanks for open-sourcing, I learnt a lot, including the
* The functionality provided by this was never used in other modules. * Record deletion is always done using Repo.delete directly. * No tests exercised this code. * Code is almost identical to same pattern shown in Ecto.Changelog docs. * Code appears to have been pasted from model-to-model as more were added.
Thanks for contributing! Code spelunking is fun
I haven't looked at this for awhile, but I'm pretty sure that these are necessary as the related
You are totally right that I haven't tested this well (there are not many tests in the admin), but you could test manually (or add tests!) by setting up an episode with some hosts/guests/channels/sponsors and then try deleting those associations on your branch. (I don't think it'll work.)
Thanks again, I love how many folks are taking the code for a spin!
Yes, you are right, these are in fact used. In the templates the
If only I'd noticed this I could have submitted some tests instead. Thanks for the reply.