Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #18

Merged
merged 15 commits into from Mar 12, 2015

Conversation

@jerodsanto
Copy link
Member

commented Mar 8, 2015

First steps toward theme support. Things left to do:

  • implement day theme
  • refine night theme from community feedback
  • swap logo based on Theme setting
  • add custom field to Nightly CM group
  • test via the Nightly Test CM group
  • tweak copy on link in footer
  • decide if we want to add a temporary message in header/footer
  • update screenshots on GH readme, subscribe page, GH Archive (?)

jerodsanto added some commits Mar 8, 2015

integrate themes in to issue view
* default to night theme for web version
* use user-selected theme for email version
* add preferences link to email version

@jerodsanto jerodsanto assigned jerodsanto and adamstac and unassigned jerodsanto Mar 8, 2015

@jerodsanto

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2015

@adamstac tag, you're it. Let me know if you have any questions. Easiest way to dev this out is to just toggle the theme css link on the web version.

adamstac added some commits Mar 9, 2015

Update to support theming
- Add base file and import into night and day
- Setup default night variables
- Setup day variables and override on import of base
- Minimize spacing, fonts, and shrink avatar size
@adamstac

This comment has been minimized.

Copy link
Member

commented Mar 9, 2015

Ok, @jerodsanto. Shipped the updates to the night and day themes. I just need your help on the best way to swap the logo based on the theme.

@jerodsanto jerodsanto merged commit e5977a7 into master Mar 12, 2015

@jerodsanto jerodsanto deleted the themes branch Mar 12, 2015

@zeke

This comment has been minimized.

Copy link

commented Mar 16, 2015

The light theme looks great. Thanks!

@jerodsanto

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2015

@zeke glad you like it! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.