Skip to content

Tim Heckman
theckman

Developer Program Member
  • San Francisco, CA
  • Joined on May 14, 2011
May 28, 2016
May 28, 2016
May 18, 2016
May 17, 2016
May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

🐑

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

🚢 🇮🇹

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

I thought about this as well - bogus data is returned (in the specs, the number 11 is returned). We could suppress this entirely if the size isn't…

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

Oh, looks like Ruby 2.0 is EOL anyhow. Probably best to remove it. 😄

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

@SarahKowalik @tristaneuan I agree with changing .travis.yml. Maybe only build for 2.1, 2.2, 2.3? It could be slipstreamed in to this change or don…

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

It's been a very long time since I've done a code review, plus I don't carry the same weight with a 👍 as before, so I'm sure it'd be good for @tris…

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

That's going to be hard to do. When you're creating the values above in the config, are an Array with one string in them. When you are accessing a …

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

Yeah, if you're only going to be using it once I think it makes sense to just use the long-form way of doing it. I was using the configuration stuf…

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

I miss doing code reviews with you lot. It's fun. 😄

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

@tristaneuan thanks dude. :)

May 13, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

It's because you're in a different class. The Enhance class inherits from the Handler class, which gives you the config helper method within that c…

May 13, 2016
May 11, 2016
theckman commented on pull request PagerDuty/lita-enhance#17
@theckman

@shortdudey123 there is a generic instance size type used to standardize what instances to use cross-provider. Its meaning depends on the cloud pro…

May 10, 2016
May 4, 2016
May 1, 2016
Apr 29, 2016
theckman commented on pull request PagerDuty/devdocs#62
@theckman

I see what you did there, McDollins.

Apr 29, 2016
Apr 19, 2016
Apr 18, 2016
Apr 18, 2016
Apr 17, 2016
Apr 17, 2016
Apr 9, 2016
Apr 6, 2016
Apr 4, 2016
Something went wrong with that request. Please try again.