New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Detect Running Service #642
Conversation
} | ||
return pidFilePath | ||
} | ||
|
||
// SpecFilepath returns the path to the REX-Ray spect file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on exported function SpecFilePath should be of the form "SpecFilePath ..."
8cb65f1
to
c8348fb
Compare
} | ||
return pidFilePath | ||
} | ||
|
||
// SpecFilePath returns the path to the REX-Ray spect file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typo in comment. "spect" vs "spec"
Oh come on. :) thanks for catching it :)
…--
-a
On Dec 2, 2016, at 5:21 PM, Travis Rhoden ***@***.***> wrote:
@codenrhoden commented on this pull request.
In util/util.go:
> }
return pidFilePath
}
+// SpecFilePath returns the path to the REX-Ray spect file.
minor typo in comment. "spect" vs "spec"
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
5322db1
to
242c77f
Compare
Current coverage is 8.46% (diff: 13.72%)@@ master #642 diff @@
========================================
Files 16 16
Lines 2087 2126 +39
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 177 180 +3
- Misses 1906 1942 +36
Partials 4 4
|
e261401
to
660c70e
Compare
This patch handles issue rexray#589 so that a REX-Ray client will automatically detect a running libStorage service if it was started by REX-Ray, even via embedded mode. This means that even if the REX-Ray configuration file relies on auto-service mode where a host is not explicitly defined, if a libStorage server is started in this manner, subsequent REX-Ray executions will not start additional servers, instead attaching to the existing service.
660c70e
to
b8ef9e4
Compare
This patch handles issue #589 so that a REX-Ray client will automatically detect a running libStorage service if it was started by REX-Ray, even via embedded mode. This means that even if the REX-Ray configuration file relies on auto-service mode where a host is not explicitly defined, if a libStorage server is started in this manner, subsequent REX-Ray executions will not start additional servers, instead attaching to the existing service.