From b97ad4541bede2f989b4d609e08729a57d71bc57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Mon, 24 Feb 2020 12:14:43 +0100 Subject: [PATCH 1/4] Hard-coding coveralls secret Putting the Coveralls secret in clear text (to be able to have coveralls info in forks) This means anyone can push information in Safe coveralls. We are ok with that "risk" --- .github/workflows/continuous-integration.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 9cd0f7f7..6c32b49d 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -127,9 +127,8 @@ jobs: path: "generator/build" - name: "Upload test coverage to coveralls" - continue-on-error: true run: "php vendor/bin/php-coveralls -v" working-directory: "generator" env: - COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} + COVERALLS_REPO_TOKEN: "jkrVNjOvNxoqfyCSQ2QbIgbqP53QCkFmP" COVERALLS_RUN_LOCALLY: 1 From 207397e34ea4523d2ad0bada37efe8b63b525c0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Mon, 24 Feb 2020 14:15:32 +0100 Subject: [PATCH 2/4] Trying Coveralls Github action --- .github/workflows/continuous-integration.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 6c32b49d..fd9a37dd 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -127,8 +127,7 @@ jobs: path: "generator/build" - name: "Upload test coverage to coveralls" - run: "php vendor/bin/php-coveralls -v" - working-directory: "generator" - env: - COVERALLS_REPO_TOKEN: "jkrVNjOvNxoqfyCSQ2QbIgbqP53QCkFmP" - COVERALLS_RUN_LOCALLY: 1 + uses: "coverallsapp/github-action@master" + with: + github-token: "jkrVNjOvNxoqfyCSQ2QbIgbqP53QCkFmP" + path-to-lcov: "generator/build/logs/clover.xml" From 448e939f57f268ad73545329f5b98a986390dde0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Mon, 24 Feb 2020 14:29:21 +0100 Subject: [PATCH 3/4] Revert "Trying Coveralls Github action" This reverts commit 207397e34ea4523d2ad0bada37efe8b63b525c0f. --- .github/workflows/continuous-integration.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index fd9a37dd..6c32b49d 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -127,7 +127,8 @@ jobs: path: "generator/build" - name: "Upload test coverage to coveralls" - uses: "coverallsapp/github-action@master" - with: - github-token: "jkrVNjOvNxoqfyCSQ2QbIgbqP53QCkFmP" - path-to-lcov: "generator/build/logs/clover.xml" + run: "php vendor/bin/php-coveralls -v" + working-directory: "generator" + env: + COVERALLS_REPO_TOKEN: "jkrVNjOvNxoqfyCSQ2QbIgbqP53QCkFmP" + COVERALLS_RUN_LOCALLY: 1 From 58f5b5f4a816688b965477eb466fff09c5c7037b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Mon, 24 Feb 2020 14:30:05 +0100 Subject: [PATCH 4/4] Debugging env vars for Coveralls --- .github/workflows/continuous-integration.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 6c32b49d..cc82cd23 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -126,6 +126,9 @@ jobs: name: "build" path: "generator/build" + - name: "Debugging env vars" + run: "env" + - name: "Upload test coverage to coveralls" run: "php vendor/bin/php-coveralls -v" working-directory: "generator"