Letsencypt http challenge #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created empty acme.json to hold letsencrypt certificates
create a volume for the letsencrypt certificate
environment variable for email to provide to let's encrypt
This reverts commit 31bbbfa.
added new compose file forDocker-compose with let's encrypt : HTTP Challenge
added instructions for usage of Docker-compose with let's encrypt
added chmod 600 for ssl/acme.json in README.md
Closed
ejoerns
reviewed
Jan 10, 2021
| Run: | ||
|
|
||
| ``` | ||
| cp .en.template .env |
There was a problem hiding this comment.
A minor note while I just read this:
Suggested change
| cp .en.template .env | |
| cp .env.template .env |
Regards, Enrico
|
Hey @benlooning, Thanks a lot for this PR. Actually, the docker-compose.yml file from the root directory is really targetted at development only and should not be used for production environments at all. Therefore, adding Let's Encrypt in this environment is a bit useless. But we are building special docker images that can be used along Let's encrypt. I recently merged #698 that is adding a brand new docker-compose file for production setups (with Let's Encrypt support). This docker-compose file is using the "official" Docker images and not the development ones (so the JS is minified, etc...) I'm closing this PR as it is superseded with #698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As so many users seem to have issues with the self-signed certificates I thought it would be a good idea to create a dedicated compose file for using traefik letsencypt http challenge. Maybe there is a better way, but this was the best I could think of.