Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inkwell cannot be built on MacOS #497

Closed
BigBadE opened this issue May 18, 2024 · 0 comments
Closed

Inkwell cannot be built on MacOS #497

BigBadE opened this issue May 18, 2024 · 0 comments
Assignees
Milestone

Comments

@BigBadE
Copy link
Contributor

BigBadE commented May 18, 2024

Describe the Bug
values/mod.rs line 228 expects section to be a &str, but a conditional compilation block uses format! to modify section, making it a String. This was introduced by #398.

To Reproduce
Build on MacOS

Expected Behavior
Build success

LLVM Version (please complete the following information):

  • LLVM Version: [e.g. 6.0]
    18.0
  • Inkwell Branch Used: [e.g. llvm6-0]
    Master

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu 16.04, Windows 10]
    MacOS 13.3 and 13.4 (Aarch64 and x86)

Additional Context
I'm opening a PR with a fix after a MacOS machine runs a test on the fixed version

@TheDan64 TheDan64 added this to the 0.5.0 milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants