Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use module_cache method instead of @module_cache #44

Merged
merged 1 commit into from

2 participants

@korny

This fixes a crash that I get on our app (@module_cache is nil). I can't really tell you why, but I wanted to share our "hotfix" in case it's really a bug.

@thedarkone
Owner

@korny if you ever get the time, would be nice if you could run your app without this fix under the debug mode (more info in the README) and provide me with the log output, so I could figure out what goes wrong.

Sorry for taking so long to respond.

@thedarkone thedarkone merged commit 5d4d34a into thedarkone:master
@thedarkone
Owner

@korny I have a new branch of rails-dev-boost/mark-then-sweep-rework in the works, it reverts your (@module_cache is nil) hotfix, can you please give it a try?

gem 'rails-dev-boost', :git => 'git://github.com/thedarkone/rails-dev-boost.git', :branch => 'mark-then-sweep-rework'
@korny

Ah, damn. We already moved to Rails 3.2 and don't use rails-dev-boost anymore. So, I can't really replicate the error, since the code changed a lot.

For some reason, I didn't see your comment 3 months ago :-/ Sorry! But I guess either somebody else can reproduce the issue, or it was very specific to our app.

@thedarkone
Owner

@korny alright, thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 3, 2013
  1. @korny
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/rails_development_boost/dependencies_patch.rb
View
2  lib/rails_development_boost/dependencies_patch.rb
@@ -398,7 +398,7 @@ def remove_explicit_dependency(const_name, depending_const)
def clear_tracks_of_removed_const(const_name, object = nil)
autoloaded_constants.delete(const_name)
- @module_cache.remove_const(const_name, object)
+ module_cache.remove_const(const_name, object)
LoadedFile.const_unloaded(const_name)
end
Something went wrong with that request. Please try again.