Skip to content

Commit

Permalink
Fix that Builder.node did not return extended elements on IE. [#71 st…
Browse files Browse the repository at this point in the history
…ate:resolved] [#77 state:resolved]
  • Loading branch information
madrobby committed Aug 28, 2008
1 parent a714120 commit 9d30ad9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG
@@ -1,3 +1,5 @@
* Fix that Builder.node did not return extended elements on IE. Closes #71 and #77.

* Fix a bug in Sortable.destroy to make sure it's called on the referenced Sortable only, which allows for the correct intialization of nested Sortables. Closes Trac #8615. [Leon Chevalier]

* Change Effect.Base#render not to use eval(), so certain JavaScript runtime environments (like Adobe AIR) that do not support eval() work. [King Maxemilian, John-David Dalton]
Expand Down
2 changes: 1 addition & 1 deletion src/builder.js
Expand Up @@ -72,7 +72,7 @@ var Builder = {
if(arguments[2])
this._children(element, arguments[2]);

return element;
return $(element);
},
_text: function(text) {
return document.createTextNode(text);
Expand Down
4 changes: 4 additions & 0 deletions test/unit/builder_test.html
Expand Up @@ -116,6 +116,10 @@ <h1>script.aculo.us Unit test file</h1>
assertEqual('mydiv', elt.htmlFor);
}},

testBuilderExtendsElement: function() { with(this) {
assertRespondsTo('hide', Builder.node('div'));
}},

testBuilderAllXHTMLTags: function() { with(this) {
var XHTML_TAGS = [
'a','abbr','acronym','address','applet','area',
Expand Down

0 comments on commit 9d30ad9

Please sign in to comment.