Nested validation is no longer supported... #63

Closed
dennis-b opened this Issue Aug 17, 2012 · 8 comments

Comments

Projects
None yet
4 participants
@dennis-b

hi

We have been using backbone.validation for about a month in our project.
It seems very user-friendly plugin and we are very pleased with him, but our whole project is built on nested models.
so we can't upgrade to v0.6.0. we going to production in 3 weeks can you please update if the nested validation will come back In the near future, if not can you suggest some work around.

Thanks!

@thedersen

This comment has been minimized.

Show comment Hide comment
@thedersen

thedersen Aug 22, 2012

Owner

Hi,

I'm sorry that I had to remove it, and its hopefully just temporarily, but I can't make any promises as to whether or not I will make it in 3 weeks..

Do you have any issues with the current version you are using?
Do you usually nest models or just json objects?

Owner

thedersen commented Aug 22, 2012

Hi,

I'm sorry that I had to remove it, and its hopefully just temporarily, but I can't make any promises as to whether or not I will make it in 3 weeks..

Do you have any issues with the current version you are using?
Do you usually nest models or just json objects?

@dennis-b

This comment has been minimized.

Show comment Hide comment
@dennis-b

dennis-b Aug 22, 2012

hi, thanks for the replay.

We using backbone model with nested json object, we cant change it now because it is our server structure.
we have several problems: required validation doesn't work for undefined values and when i use forceUpdate flag (we need it for the modelBinder) the validation are running but not stopping save/fetch operations.

hi, thanks for the replay.

We using backbone model with nested json object, we cant change it now because it is our server structure.
we have several problems: required validation doesn't work for undefined values and when i use forceUpdate flag (we need it for the modelBinder) the validation are running but not stopping save/fetch operations.

@thedersen

This comment has been minimized.

Show comment Hide comment
@thedersen

thedersen Aug 26, 2012

Owner

I'm not aware of any issues with the required validation (undefined values works in the unit tests). Can you perhaps give some more information?

When you are using forceUpdate you basically allow your model to be in an invalid state, and thus you are also allowed to save an invalid model. To prevent this, you need to manually check model.isValid() before saving.

Owner

thedersen commented Aug 26, 2012

I'm not aware of any issues with the required validation (undefined values works in the unit tests). Can you perhaps give some more information?

When you are using forceUpdate you basically allow your model to be in an invalid state, and thus you are also allowed to save an invalid model. To prevent this, you need to manually check model.isValid() before saving.

@idosius

This comment has been minimized.

Show comment Hide comment
@idosius

idosius Oct 23, 2012

I would really like to use the library, it looks great. Unfortunately there is no support for nested validation anymore while all my models contain plenty of nested objects.

When is support planned for nested validation, if at all?

idosius commented Oct 23, 2012

I would really like to use the library, it looks great. Unfortunately there is no support for nested validation anymore while all my models contain plenty of nested objects.

When is support planned for nested validation, if at all?

@deefour

This comment has been minimized.

Show comment Hide comment
@deefour

deefour Oct 29, 2012

@thedersen is there any plan to add nested validation back? It seems I'm not alone in this missing feature being a deal-breaker to use this otherwise great looking project in my application.

deefour commented Oct 29, 2012

@thedersen is there any plan to add nested validation back? It seems I'm not alone in this missing feature being a deal-breaker to use this otherwise great looking project in my application.

@thedersen

This comment has been minimized.

Show comment Hide comment
@thedersen

thedersen Oct 29, 2012

Owner

When I can find some time to work on the project, it's on the top of my
list. I am quite busy with other projects atm, so I can't make any promises
as to when this will be added.

A pull request is always welcome:-)

-Thomas

On 29. okt. 2012, at 19:02, Jason Daly notifications@github.com wrote:

@thedersen https://github.com/thedersen is there any plan to add nested
validation back? It seems I'm not alone in this missing feature being a
deal-breaker to use this otherwise great looking project in my application.


Reply to this email directly or view it on
GitHubhttps://github.com/thedersen/backbone.validation/issues/63#issuecomment-9878985.

Owner

thedersen commented Oct 29, 2012

When I can find some time to work on the project, it's on the top of my
list. I am quite busy with other projects atm, so I can't make any promises
as to when this will be added.

A pull request is always welcome:-)

-Thomas

On 29. okt. 2012, at 19:02, Jason Daly notifications@github.com wrote:

@thedersen https://github.com/thedersen is there any plan to add nested
validation back? It seems I'm not alone in this missing feature being a
deal-breaker to use this otherwise great looking project in my application.


Reply to this email directly or view it on
GitHubhttps://github.com/thedersen/backbone.validation/issues/63#issuecomment-9878985.

@thedersen

This comment has been minimized.

Show comment Hide comment
@thedersen

thedersen Nov 24, 2012

Owner

It's back. Hope you like it:)

Feedback is always welcome.

Owner

thedersen commented Nov 24, 2012

It's back. Hope you like it:)

Feedback is always welcome.

@thedersen thedersen closed this Nov 24, 2012

@dennis-b

This comment has been minimized.

Show comment Hide comment
@dennis-b

dennis-b Nov 24, 2012

thanks we will try as soon as possible !!!

thanks we will try as soon as possible !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment