Reuse Fix for URL Encoded Input and Cache Fix for v1 API #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rings; Added generation of a new key when adding a link to Redis to avoid returning links for the wrong target;
poeti8
reviewed
Nov 29, 2020
|
|
||
| export const getBoolean = (input: any): boolean => { | ||
| switch(String(input).toLowerCase()) { | ||
| case "false": case "no": case "0": case "": return false; |
There was a problem hiding this comment.
undefined and null are not handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a simple update to parse a boolean from the
reuseinput when creating links. It was always a truthy value when using the API withx-www-form-urlencodedinput unless you leave it out or send an empty string which caused unexpected behavior.I also noticed that new links were always added to the Redis cache as
'undefined--{user_id}'in the v1 API resulting in calls with'reuse': trueto return the first link added to cache (which often has a different target), so I added generation of a new key when adding a link to cache. It looks like that has already been done in the v2 API.