Corrected TypeScript type definitions so that both HTTP and HTTPS servers are supported #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vers are supported
alexmnyc
approved these changes
Jan 9, 2020
|
Thanks for approving the PR, @alexmnyc, much appreciated! Could you please advise when the change might get released to npm? |
|
@jan-molak outstanding work and great catch. I will publish right now. |
|
All set @jan-molak , it's up on NPM. Thanks again |
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Jan 10, 2020
Huge thanks to @thedillonb and @alexmnyc for getting thedillonb/http-shutdown#18 released so quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hey @thedillonb and thanks for your work on
http-shutdown!I use it as part of the Serenity/JS project to allow people to manage local test servers.
I noticed that the change introduced in version 1.2.1 breaks backwards compatibility and prevents TypeScript code from passing a HTTPs server to
http-shutdown.In order to address that issue, the type of the
Serverobject needs to be changed fromhttp.Servertonet.Server.That's because in the inheritance chain, the
net.Servertype is the first common element:https.Server -> tls.Server -> net.Server -> events.EventEmitterhttp.Server -> net.Server -> events.EventEmitterPlease let me know if your happy with this PR or if you'd like me to provide any additional details!
I've tested
http-shutdownto death in the context of Serenity/JS, so am fairly confident that the only issue that needs addressing is the type definitions :-)All the best,
Jan