Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
thedjpetersen/subway
02JanDal/subway
4a256b6b3e7t3e8b7t9q7t/subway
AlexHendy98/subway
Artogn/subway
BlancosWay/subway
DavidPsy/subway
Dessimat0r/subway
FLamparski/subway
Fauntleroy/subway
Freetable/subway
Ibuprofen/subway
JaTochNietDan/subway
JamyDev/subway
KOBA789/subway
LocalSense/subway
Lullabot/subway
Olink/subway
Raynes/subway
RolePlayGateway/subway
Sigterm-no/subway
SirensOfTitan/subway
SpenserJ/subway
Stackato-Apps-1-0/subway
Stackato-Apps/subway
Sumukh/subway
TheDgtl/subway
aaroncrespo/subway
adrexia/subway
akavlie/subway
andypiper/subway
applecool/subway
armuk/subway
astorije/subway
axitkhurana/subway
aya/subway
badosu/subway
bagobor/subway
balgarath/subway
billyvg/subway
bitmatica/subway
bsiegel/subway
c0redumped/subway
carriercomm/subway
chiguireitor/subway
chrisrhoden/subway
cjb/subway
clkao/subway
cloudfoundry-samples/subway
codafoo/subway
cordoval/subway
crodjer/subway
cruzrr/subway
dallincrane/subway
davidbanham/subway
dbkaplun/subway
derek-smith/subway
deviantintegral/subway
dineshkummarc/subway
dismalNiche/subway
divyekapoor/subway
docwhat/subway
domesticc/subway
donoftime/subway
ebits/subway
edkellena/subway
eirikb/subway
ericelliott/subway
fakedrake/subway
gh0std4ncer/subway
gijs/subway
goodwillhacking/subway
gstack/gcam-irc
hermansc/subway
hifans/subway
hikikomorime/subway
hlindset/subway
hnrc/subway
hoxca/subway
hull-graveyard/subway
ianloic/subway
igorhvr/subway
imclab/subway
infoburp/subway
jamespthomas/subway
jamiees2/subway
jamiepg1/subway
jbfink/subway
jd-258/subway
joelfire/subway
joeyAghion/subway
johsoe/subway
joona/subway
jrsdead/subway
jsolis/subway
juilyoon/subway
juliangruber/subway
justin3737/subway
kashopi/subway
kategengler/subway
kernicPanel/subway
kode54/subway
kparaju/subway
kvo22/subway
kwamaking/subway
l0gicpath/subway
lgbtIM/subway
liamcurry/subway
ludovicdeluna/subway
machuga/subway
maikelwever/subway
maniacs-oss/subway
mannytoledo/subway
marcoceppi/subway
martindale/subway
mathias/subway
mbilker/subway
mikalv/subway
mjw56/subway
mozillamonks/subway
mylons/subway
nemstar/subway
ngokevin/subway
nibalizer/subway
niftylettuce/subway
nijikokun/subway
nod/subway
nrn/subway
ntulip/subway
nunogt/subway
olivermt/subway
olivierh59500/subway
overra/subway
pdxcat/subway
phpdevops/subway
ping86/subway
predominant/subway
qluan/subway
quajo/subway
rayshan/subway
robbl/subway
rodms10/subway
ryelle/subway
sethdford/subway
shaunduncan/subway
simonify/subway
sivarenganathan/subway
slobo/subway
smillaedler/subway
stelcheck/subway
steverob/subway
subterfugium/subway
techalchemy/subway
thedangler/subway
themgt/subway
tjfontaine/subway
tobeee/subway
tobmaster/subway
tomusdrw/subway
totokaka/subway
tougbia09/subway
ultrahang/subway
utatti/subway
utdlug/lug-webirc
vinnymac/subway
vongrippen/subway
whiskers75/subway
wookimiii/subway
xobs/subway
xujianrj/subway
yhsiang/subway
youngershen/subway
yyolk/yawbus
zhangshiguang/subway
zz3599/subway
Nothing to show
Choose a base branch
Nothing to show
...
Choose a Head Repository
thedjpetersen/subway
02JanDal/subway
4a256b6b3e7t3e8b7t9q7t/subway
AlexHendy98/subway
Artogn/subway
BlancosWay/subway
DavidPsy/subway
Dessimat0r/subway
FLamparski/subway
Fauntleroy/subway
Freetable/subway
Ibuprofen/subway
JaTochNietDan/subway
JamyDev/subway
KOBA789/subway
LocalSense/subway
Lullabot/subway
Olink/subway
Raynes/subway
RolePlayGateway/subway
Sigterm-no/subway
SirensOfTitan/subway
SpenserJ/subway
Stackato-Apps-1-0/subway
Stackato-Apps/subway
Sumukh/subway
TheDgtl/subway
aaroncrespo/subway
adrexia/subway
akavlie/subway
andypiper/subway
applecool/subway
armuk/subway
astorije/subway
axitkhurana/subway
aya/subway
badosu/subway
bagobor/subway
balgarath/subway
billyvg/subway
bitmatica/subway
bsiegel/subway
c0redumped/subway
carriercomm/subway
chiguireitor/subway
chrisrhoden/subway
cjb/subway
clkao/subway
cloudfoundry-samples/subway
codafoo/subway
cordoval/subway
crodjer/subway
cruzrr/subway
dallincrane/subway
davidbanham/subway
dbkaplun/subway
derek-smith/subway
deviantintegral/subway
dineshkummarc/subway
dismalNiche/subway
divyekapoor/subway
docwhat/subway
domesticc/subway
donoftime/subway
ebits/subway
edkellena/subway
eirikb/subway
ericelliott/subway
fakedrake/subway
gh0std4ncer/subway
gijs/subway
goodwillhacking/subway
gstack/gcam-irc
hermansc/subway
hifans/subway
hikikomorime/subway
hlindset/subway
hnrc/subway
hoxca/subway
hull-graveyard/subway
ianloic/subway
igorhvr/subway
imclab/subway
infoburp/subway
jamespthomas/subway
jamiees2/subway
jamiepg1/subway
jbfink/subway
jd-258/subway
joelfire/subway
joeyAghion/subway
johsoe/subway
joona/subway
jrsdead/subway
jsolis/subway
juilyoon/subway
juliangruber/subway
justin3737/subway
kashopi/subway
kategengler/subway
kernicPanel/subway
kode54/subway
kparaju/subway
kvo22/subway
kwamaking/subway
l0gicpath/subway
lgbtIM/subway
liamcurry/subway
ludovicdeluna/subway
machuga/subway
maikelwever/subway
maniacs-oss/subway
mannytoledo/subway
marcoceppi/subway
martindale/subway
mathias/subway
mbilker/subway
mikalv/subway
mjw56/subway
mozillamonks/subway
mylons/subway
nemstar/subway
ngokevin/subway
nibalizer/subway
niftylettuce/subway
nijikokun/subway
nod/subway
nrn/subway
ntulip/subway
nunogt/subway
olivermt/subway
olivierh59500/subway
overra/subway
pdxcat/subway
phpdevops/subway
ping86/subway
predominant/subway
qluan/subway
quajo/subway
rayshan/subway
robbl/subway
rodms10/subway
ryelle/subway
sethdford/subway
shaunduncan/subway
simonify/subway
sivarenganathan/subway
slobo/subway
smillaedler/subway
stelcheck/subway
steverob/subway
subterfugium/subway
techalchemy/subway
thedangler/subway
themgt/subway
tjfontaine/subway
tobeee/subway
tobmaster/subway
tomusdrw/subway
totokaka/subway
tougbia09/subway
ultrahang/subway
utatti/subway
utdlug/lug-webirc
vinnymac/subway
vongrippen/subway
whiskers75/subway
wookimiii/subway
xobs/subway
xujianrj/subway
yhsiang/subway
youngershen/subway
yyolk/yawbus
zhangshiguang/subway
zz3599/subway
Nothing to show
Choose a head branch
Nothing to show
This comparison is big! We’re only showing the most recent 250 commits
Commits on Jan 21, 2013
Commits on Feb 04, 2013
escape regex characters
Usernames containing regular expression characters break formatting
Merge pull request #203 from eirikb/unread-suggestion
Don't show unread-label on open (active) channel/chat
Commits on Feb 05, 2013
Merge pull request #209 from Ibuprofen/patch-1
escape regex characters in mentions
Commits on Feb 07, 2013
Commits on Feb 19, 2013
Commits on Feb 28, 2013
Commits on Mar 01, 2013
Commits on Mar 03, 2013
Commits on Mar 04, 2013
Commits on Mar 09, 2013
Commits on Mar 11, 2013
Commits on Mar 29, 2013
Commits on May 04, 2013
Added handling for other user's actions
Your /me actions would display fine but other user's actions would not
display. This solves that issue.
Merge pull request #236 from JaTochNietDan/master
Adds handling for other people's actions.
Beginnings of 0.3 refactor (sqlite db, asset libs updated, multi-conn…
…ection support). This is all really broken right now. Making good progress though.
Commits on May 05, 2013
Commits on May 06, 2013
Commits on May 08, 2013
Commits on May 09, 2013
Commits on May 10, 2013
Commits on May 30, 2013
Commits on Jun 15, 2013
Commits on Jun 17, 2013
Commits on Jun 19, 2013
Minor changes to desktop notification support.
- Applied backbone getters
- Moved code into function driven by new messageNotification event
- === instead of ==
Commits on Jul 02, 2013
Commits on Jul 30, 2013
Replaced node-orm2 with jugglingdb due to build issues and broken-nes…
…s of code. NOTE: You may need to delete your existing subway.db for this to work!
Commits on Aug 06, 2013
Commits on Aug 07, 2013
Merge pull request #257 from badosu/add-notice-messages-to-chatwindow
Add notice messages to chatWindow when present
Commits on Aug 09, 2013
Commits on Aug 10, 2013
Commits on Aug 11, 2013
Commits on Aug 12, 2013
Commits on Aug 13, 2013
Commits on Sep 27, 2013
Commits on Oct 07, 2013
Merge pull request #271 from kparaju/master
Do getValue() of Boolean objects before comparing them
Commits on Nov 21, 2013
Commits on Nov 22, 2013
Commits on Nov 23, 2013
Commits on Jan 01, 2014
nrn
Set connected to false on disconnect
Make leave dialog only pop up when connected
and logged in.
Commits on Jan 02, 2014
Merge pull request #280 from nrn/master
Set connected to false on disconnect
Commits on Jan 18, 2014
BYK
Fix port mismatch when used behind a reverse proxy
Websockets port is always the same as the static web server port so
instead of having some tricks, this patch simply removes that and uses
`document.location.protocol` for the port.
Commits on Jan 19, 2014
Commits on Feb 14, 2014
Changed desktop notifications to support Firefox.
Pretty much everything of the notification handling was redone.
This is tested on Chromium version '32.0.1700.107 (248368)' and
Firefox version 29 and 27 under linux. More testing would be nice.
Commits on Feb 15, 2014
Adds confirmation dialog and help text to server and channel close.
In order to improve the UX this commit adds a confirmation dialog when
closing the connection to the server. It also adds a 'title'-tag over
the close-icon (an 'x') informing the user that pressing this button
will result in either leaving network or channel.
Fixes bug where one could register with empty username or password.
After commit 48bf2d6 it became possible to register with an empty username
and/or password. In fact, the checks ensuring a value in the username and
password fields were referencing legacy classes and no longer working. I thus
changed to a horizontal form per Twitter Bootstrap documentation[0] and added
some validation states informing the user of what is wrong.

[0]: http://getbootstrap.com/2.3.2/base-css.html#forms
Commits on Feb 16, 2014
Gives user notification when a username is already registered.
The server actually sent an event called 'register_error', but there were
nothing client-side that listened for it. This commit mitigates this.
It also clears up any old messages, so that they don't stack up, but rather
flashes when entering multiple bad passwords or already registered usernames.
Adds some common command shortcuts
This commit introduces aliases found, among other clients, in irssi:

    /j -> /join
    /t -> /topic
    /q -> /query
Merge pull request #297 from hermansc/register-form-alerts
Gives user notification when a username is already registered.
Merge pull request #295 from hermansc/login-form-fix
Fixes bug where one could register with empty username or password.
Merge pull request #293 from hermansc/close-confirmation-dialog
Adds confirmation dialog and help text to server and channel close.
Merge pull request #291 from totokaka/desktop-notifications
Changed desktop notifications to support Firefox.
Adds cookie based login, also called "remember me"-functionality.
This commit fixes issue #284 by adding cookies/authentication tokens at the
client side and validating these in the DB. When a user either registers or
logs in, without already having a cookie, a sha1-hash is generated using the
username and a secret key. This hash is stored in a DB-table calles 'Session'
and client side using the jquery-cookie plugin. When closing and opening the
application again we check if the users have a 'auth_token' in their cookies,
if this is the case we check its validity in the DB. If everything is OK, we
'jump through the hoops' and sets the user as logged in, restores his/hers
connections and render the chat_application. If it is not valid we delete the
cookie at the client and render the overview page.

As I've never actually implemented a cookie-based login system using javascript
before, I do not know if this solution is optimal and I'm more than happy to
discuss alternative approaches or restructure the code.
Commits on Feb 17, 2014
Adds button for joining a channel without writing /join
Fixes issue #123 and adds a button under the channel list for easily inputing a
channel name and pressing enter. This should make it more easy for new users to
IRC, joining channels. Someone with a better feel for UI may want to look at
how to make this prettier and even simpler.
Merge pull request #300 from hermansc/new-channel
Adds button for joining a channel without writing /join
Commits on Feb 18, 2014
Commits on Feb 20, 2014
Improves home-button design and form-design
Adds a glyphicon icon for the home button, adds some styling and removes
styles which are already implemented in bootstrap. Lastly it writes some
classes in ids in "jade-style" and not inside parentheses.
Commits on Feb 23, 2014
Commits on Feb 24, 2014
Commits on Feb 25, 2014
Commits on Feb 27, 2014
Commits on Feb 28, 2014
Commits on Mar 03, 2014
Commits on Mar 05, 2014
Commits on Mar 06, 2014
Commits on Mar 11, 2014
Commits on Mar 13, 2014
Commits on Mar 14, 2014
Commits on Mar 19, 2014
Commits on Mar 20, 2014
Commits on Mar 21, 2014
Merge pull request #316 from pschichtel/patch-1
Added a nginx configuration and an init script
Commits on Apr 03, 2014
Commits on Apr 08, 2014
Commits on Apr 18, 2014
Commits on Apr 21, 2014
Commits on Apr 24, 2014
Commits on Apr 27, 2014
cjb
Load fonts over SSL if Subway is on SSL, otherwise they won't load
Chrome: [blocked] The page at 'https://foo/' was loaded over HTTPS, but ran insecure content from 'http://fonts.googleapis.com/css?family=Open+Sans:400italic,400,300,600,700,800': this content should also be loaded over HTTPS.
Merge pull request #325 from cjb/fix-font-load
Load fonts over SSL; otherwise they won't load when Subway is on SSL
Commits on Apr 28, 2014
Commits on Apr 30, 2014
Commits on May 01, 2014
Commits on May 04, 2014
Commits on May 08, 2014
Commits on May 09, 2014
Commits on May 15, 2014
Commits on May 17, 2014
Commits on May 29, 2014
README: Added link to #292
Just a simple change.
Commits on May 30, 2014
Commits on Jun 09, 2014
Commits on Jun 11, 2014
Commits on Jun 13, 2014
Commits on Jun 28, 2014
Commits on Jul 04, 2014
Commits on Aug 04, 2014
Commits on Aug 12, 2014
Commits on Aug 13, 2014
Commits on Aug 16, 2014
Commits on Aug 19, 2014
Commits on Aug 20, 2014
Commits on Aug 23, 2014
Commits on Aug 29, 2014
Commits on Aug 30, 2014
Commits on Sep 13, 2014
Commits on Oct 08, 2014
Commits on Nov 03, 2014
Commits on Nov 06, 2014
Commits on Nov 12, 2014
Commits on Dec 04, 2014
Commits on Dec 17, 2014
Commits on Jan 03, 2015
Update README.md
Add what would appear to be a deprecation notice as well as promise to continue work in future
Update README.md
Add missing period
Commits on Jan 06, 2015
Commits on Apr 29, 2016
Showing with 4,391 additions and 6,652 deletions.
  1. +5 −0 .bowerrc
  2. +4 −2 .gitignore
  3. +13 −46 README.md
  4. +0 −9 assets/css/bootstrap.min.css
  5. +0 −473 assets/css/subway.css
  6. BIN assets/images/active.png
  7. +0 −3 assets/images/connection.svg
  8. BIN assets/images/favicon.ico
  9. BIN assets/images/glyphicons-halflings-white.png
  10. BIN assets/images/glyphicons-halflings.png
  11. BIN assets/images/idle.png
  12. BIN assets/images/join.png
  13. BIN assets/images/loading.gif
  14. +0 −8 assets/images/login.svg
  15. BIN assets/images/part.png
  16. +0 −24 assets/images/register.svg
  17. +0 −25 assets/images/settings.svg
  18. BIN assets/images/topic.png
  19. +0 −467 assets/js/client.js
  20. +0 −110 assets/js/collections.js
  21. +0 −9 assets/js/libs/ICanHaz.min.js
  22. +0 −38 assets/js/libs/backbone-min.js
  23. +0 −6 assets/js/libs/bootstrap.min.js
  24. +0 −4 assets/js/libs/jquery-1.7.1.min.js
  25. +0 −11 assets/js/libs/jquery.scrollTo-1.4.2-min.js
  26. +0 −3,751 assets/js/libs/socket.io.js
  27. +0 −32 assets/js/libs/underscore-min.js
  28. +0 −83 assets/js/models.js
  29. +0 −71 assets/js/utils.js
  30. +0 −19 assets/js/views/channel_list.js
  31. +0 −79 assets/js/views/channel_tab.js
  32. +0 −215 assets/js/views/chat.js
  33. +0 −106 assets/js/views/chat_application.js
  34. +0 −71 assets/js/views/message.js
  35. +0 −131 assets/js/views/overview.js
  36. +0 −55 assets/js/views/user_list.js
  37. +0 −12 assets/sounds/LICENSE.txt
  38. +15 −0 bower.json
  39. +0 −15 config.js
  40. +490 −0 lib/connection.js
  41. +40 −0 lib/debug.js
  42. +0 −187 lib/irclink.js
  43. +41 −35 lib/models.js
  44. +71 −0 lib/plugins.js
  45. +0 −18 lib/restore.js
  46. +0 −210 lib/socket.js
  47. +189 −0 lib/static.js
  48. +0 −35 lib/subway.js
  49. +0 −37 lib/webserver.js
  50. +32 −18 package.json
  51. +1 −0 plugin_cache/README.md
  52. +39 −0 settings/client.js
  53. +52 −0 settings/server.js
  54. +224 −0 src/components/app/messageInput.jsx
  55. +195 −0 src/components/app/messages.jsx
  56. +36 −0 src/components/app/userList.jsx
  57. +240 −0 src/components/irc.jsx
  58. +393 −0 src/components/menu.jsx
  59. +71 −0 src/components/settings/general.jsx
  60. +136 −0 src/components/settings/highlight.jsx
  61. +227 −0 src/components/settings/plugins.jsx
  62. +14 −0 src/img/bubbles.svg
  63. BIN {assets/images → src/img}/subway.png
  64. +20 −0 src/jade/debug.jade
  65. +32 −0 src/jade/index.jade
  66. +82 −0 src/js/app.js
  67. +288 −0 src/js/boilerplate.js
  68. +9 −0 src/js/debug.js
  69. +259 −0 src/js/handle_irc.js
  70. +361 −0 src/js/models/models.js
  71. +34 −0 src/js/util.js
  72. BIN {assets → src}/sounds/msg.mp3
  73. BIN {assets → src}/sounds/msg.ogg
  74. BIN {assets → src}/sounds/new-pm.mp3
  75. BIN {assets → src}/sounds/new-pm.ogg
  76. +11 −0 src/styl/app.styl
  77. +101 −0 src/styl/base.styl
  78. +12 −0 src/styl/buttons.styl
  79. +11 −0 src/styl/debug.styl
  80. +38 −0 src/styl/layout.styl
  81. +146 −0 src/styl/mainMenu.styl
  82. +56 −0 src/styl/message.styl
  83. +49 −0 src/styl/messageInput.styl
  84. +79 −0 src/styl/nav.styl
  85. +7 −0 src/styl/type.styl
  86. +33 −0 src/styl/userList.styl
  87. 0 src/styl/variables.styl
  88. +0 −6 subway
  89. +96 −0 subway.js
  90. +19 −0 support/README.md
  91. +85 −0 support/init.d/subway
  92. +35 −0 support/nginx/subway
  93. +0 −2 views/index.jade
  94. +0 −15 views/layout.jade
  95. +0 −214 views/templates.jade
View
@@ -0,0 +1,5 @@
+{
+ "directory": "src/libs",
+ "json": "bower.json",
+ "endpoint" : "https://bower.herokuapp.com"
+}
View
@@ -1,3 +1,5 @@
+tmp/
node_modules/
-builtAssets/
-run.sh
+src/libs/
+plugin_cache/
+*.db
View
@@ -1,6 +1,8 @@
Subway
======
+*Subway is not currently functional and not under active development. While the plan is to finish this project some point in the future, currently the maintainer strongly suggests taking a look at [The Lounge](https://github.com/thelounge/lounge).*
+
Subway is a web-based IRC client with a multi-user backend and a
JavaScript-heavy UI. Frontend/backend communication is done with
websockets (or best available fallback where not available).
@@ -9,21 +11,21 @@ browser disconnects.
Subway is built with [node.js](http://nodejs.org/),
[node-irc](https://github.com/martynsmith/node-irc)
-and [MongoDB](http://www.mongodb.org/) on the backend,
-and [Backbone.js](http://documentcloud.github.com/backbone/) and
+and [Backbone.js](http://documentcloud.github.com/backbone/)/ReactJS and
[jQuery](http://jquery.com/) on the frontend.
Screenshots
------------
-![Overview](http://people.oregonstate.edu/~petersed/overview.png)
-![Chat](http://people.oregonstate.edu/~petersed/chat.png)
+
+![Chat](http://i.imgur.com/y56tLP9.png)
+![Settings](http://i.imgur.com/hgwRzHq.png)
Installation
------------
*Should be something like this, once implemented:*
-1. Assuming you already have node.js, npm, and mongo, run:
+1. Assuming you already have node.js, and npm, run:
$ git clone https://github.com/thedjpetersen/subway.git
$ cd subway
@@ -34,67 +36,32 @@ Installation
3. Launch the web server
- $ node subway
+ $ ./subway.js
4. Point your browser at `http://localhost:3000/`
-Deployment
------------
-### Nodejitsu
-To deploy to Nodejitsu, update the `name` and `subdomain` values in `package.json` to the appropriate values for your app. Then:
-
- $ jitsu databases create mongo subway
-
-Now change the line `mongoose.connect('mongodb://localhost/subway');` in lib/irchandler.js to the connect URI you got back from jitsu. Then:
-
- $ jitsu env set PORT 80
- $ jitsu deploy
-
-
Development
-----------
-Discussion about the client takes place on the freenode channel **#subway**, and on
-this repository's [Issues](https://github.com/thedjpetersen/subway/issues) page.
+Discussion about the client takes place on this repository's [Issues](https://github.com/thedjpetersen/subway/issues) page.
Contributors are welcome and greatly appreciated.
-History
+Goals
-------
-Subway is a combination of two projects that started independently
-with a similar technology stack and similar aims:
-
-- [subway-web](https://github.com/thedjpetersen/subway-web) /
- [subway-server](https://github.com/thedjpetersen/subway-server)
- by David Petersen
-- [web-irc](https://github.com/akavlie/web-irc) by Aaron Kavlie
-
Its goals are twofold:
+
1) Become the best web-based IRC client available
+
2) Provide a really easy method of persistent IRC connections, available
from any web browser
The inspiration for Subway was trying to watch a fellow programmer try
to explain how to set up screen/irssi to a non-technical person.
-Credits
--------
-
-Major Subway contributors include:
-
-- [David Petersen](https://github.com/thedjpetersen), developer
-- [Aaron Kavlie](https://github.com/akavlie), developer
-- [Eric Barch](https://github.com/ericbarch), developer
-- [HyeonJe Jun](https://github.com/noraesae), developer
-- [Jamie Soar](http://www.jamiesoarmusic.co.uk/), notification sounds
-- Yusuke Kamiyamane, some icons
-
-**The logo right now is a Gowalla icon, we are not planning on keeping this, we are only planning on using it as a placeholder**
-
-
License
-------
@@ -103,7 +70,7 @@ or directories), this project is covered by the MIT License:
The MIT License (MIT)
-Copyright (c) 2011 David Petersen
+Copyright (c) 2015 David Petersen
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in

Large diffs are not rendered by default.

Oops, something went wrong.
Oops, something went wrong.

Showing you all comments on commits in this comparison.

Contributor

JaTochNietDan commented on 4844283 May 5, 2013

Hi Eric, with this scroll change you've made it so that the embedded images/videos are bugging it out again and it doesn't auto-scroll passed them.

Collaborator

ericbarch commented on 4844283 May 5, 2013

Hmm...could you test your code again and send another pull request? Prior to this all of my chat windows were scrolling right to the top and wouldn't let me scroll down anymore.

Contributor

JaTochNietDan commented on 4844283 May 5, 2013

Right....well I'm not sure then. I tested that code before submitting the original pull request and it was working as intended on my end. It also seems to make more sense to check if the scrollbar is at the bottom beforehand so you don't have to count in for height added by appended messages.

Then once it has been appended, you can simply get the new height and scroll to the end. I'm unsure as to why the fix was causing issues on your end.

Collaborator

ericbarch commented on 4844283 May 5, 2013

What browser/OS are you testing against? I'm seeing the issue in Chrome 26/OS X.

Contributor

JaTochNietDan commented on 4844283 May 5, 2013

I'm on Windows 8 Professional x64 using Chrome 26.

Contributor

cwc commented on 3b7b4b1 May 10, 2013

Thanks for this. I was literally just about to add it myself. 😁

Collaborator

badosu commented on dd035e5 Aug 13, 2013

Cool! Thanks!

uberj commented on d5ccf21 Dec 15, 2013

Happy Birthday.

Owner

thedjpetersen commented on d5ccf21 Dec 16, 2013

<3 what a nice way to start Monday

Contributor

ngokevin commented on d5ccf21 Dec 18, 2013

How was the party?! :)

Owner

thedjpetersen commented on d5ccf21 Dec 18, 2013

So good(not great because it was missing you!) - my wife is super amazing.

Contributor

ngokevin commented on d5ccf21 Dec 18, 2013

Your wife is awesome. She personally invited both of us, and we almost made it up there. I really, really wanted to go (would've been a crazy surprise). That's why I want to go to Seattle sometime soon, but not sure when.

Contributor

totokaka commented on 7d99b98 Mar 5, 2014

This is not needed. The desktopNorification method is bound to the messageNotification event, so it is only called when you are mentioned, se line 35

EDIT: It seems I might have missunderstood what this commit does. If this commit should "fix", the non-existing, issue that the notification is displayed whenever a message is displayed, the original message applies. If it, however, is intended to always display the desktop notification when the user is mentioned, also when the window is active, the correct way would be to just remove the if-statement. Basically this commit does not change functionallity in any way, as it is now.

Contributor

jsolis commented on 7d99b98 Mar 5, 2014

So my intent was the second case which was to always show the notifications when you are mentioned or PM'ed. The reasoning was that if my tab is in the foreground of my browser, but my browser is in the background, I do not get a notification for a DM or PM but I would want to in this case. I see your point however that the condition should really just be removed in this case. I didn't dig deep enough to realize this when I made this change. When I sent my pull request, this change wasn't intended to be included yet because I had a feeling I wasn't doing it right yet. Ideally this feature would be a user settings option so people can pick how often they get nagged for DM and PMs.

Contributor

totokaka commented on 7d99b98 Mar 6, 2014

Hmm, I do not believe the per user config will ever be implemented in this branch. Thedjpetersen has started a rewrite, and that will probably contain the per user settings.

The way to fix your problem should either be to remove the if statement, or find a way to check if the browser is in the background.

Owner

thedjpetersen commented on 30a534d Dec 4, 2014

Most likely fixes #345