make 'keeping connection alive' optional #168

Merged
merged 1 commit into from Oct 2, 2012

Conversation

Projects
None yet
2 participants
Collaborator

utatti commented Sep 29, 2012

Make 'keeping connection alive after browser closed' feature optional and user-selectable.

I created the checkbox in server connection form.

If the user checked 'Keep connection alive..', the connection'll be kept alive after the browser is closed.

If not, the irc connection closed when the browser closed but it remember the server and channels, and when the user log in later, the user'll be connected with the setting the user used.

But for this patch, I can't assure if this changes are right(or best) way to implement this.
Please review the code, and let me know if there's something i can make better.
Also, you can test this patch here : http://subway.yuiazu.net/

Thanks.

Collaborator

utatti commented Sep 29, 2012

this patch is for #166

thedjpetersen added a commit that referenced this pull request Oct 2, 2012

Merge pull request #168 from noraesae/master
make 'keeping connection alive' optional

@thedjpetersen thedjpetersen merged commit 9505050 into thedjpetersen:master Oct 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment