Better comand handling, whois command #170

Merged
merged 2 commits into from Oct 2, 2012

Projects

None yet

3 participants

Contributor
crodjer commented Sep 30, 2012

Asking for whois info is quite popular. This adds it to the server
and the client side.

A better, extensible command handler and store, which can be
used for implemening functionalities like autocomplete, help etc.

@noraesae noraesae and 1 other commented on an outdated diff Sep 30, 2012
lib/irclink.js
@@ -79,7 +80,7 @@ var IRCLink = function(hostname, port, ssl, selfSigned, nick, realName, password
for (var i = 0; i < instance.sockets.length; i++) {
instance.sockets[i].emit(event, args);
}
-
noraesae
noraesae Sep 30, 2012 Collaborator

I think this line doesn't have to be changed.
Trailing spaces are not good, but a patch must only include the things concerned with the patch itself.
Please remove this change.

crodjer
crodjer Sep 30, 2012 Contributor

Hi, thanks for the prompt replies. I have updated my commits as per
your suggestions. To keep the history clean, the commit ids are
changed, so they will look like fresh commits.

On 12:37 -0700 / 30 Sep, HyeonJe, Jun wrote:

@@ -79,7 +80,7 @@ var IRCLink = function(hostname, port, ssl, selfSigned, nick, realName, password
for (var i = 0; i < instance.sockets.length; i++) {
instance.sockets[i].emit(event, args);

}

I think this line doesn't have to be changed.
Trailing spaces are not good, but a patch must only include the things concerned with the patch itself.
Please remove this change.


Reply to this email directly or view it on GitHub:
https://github.com/thedjpetersen/subway/pull/170/files#r1724964

@noraesae noraesae commented on an outdated diff Sep 30, 2012
lib/subway.js
+module.exports = Subway;
noraesae
noraesae Sep 30, 2012 Collaborator

This line too.
lib/Subway.js doesn't need to be changed.
Please exclude 'lib/subway.js' in the commit.

crodjer added some commits Sep 30, 2012
@crodjer crodjer Support for whois command
Asking for whois info is quite popular. This adds it to the server
and the client side.

Signed-off-by: Rohan Jain <crodjer@gmail.com>
8fe5ae4
@crodjer crodjer Command store and better command handler
This doesn't add and functionality right now, but it can be used for
functionalities like autocomplete, help text.

Signed-off-by: Rohan Jain <crodjer@gmail.com>
80c335b
Owner

Looks good to me thanks.

@thedjpetersen thedjpetersen merged commit be164f8 into thedjpetersen:master Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment