Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Don't show unread-label on open (active) channel/chat #203

Merged
merged 1 commit into from

3 participants

@eirikb

Suggestion: Don't show the label for unread messages on incoming messages to an already open chat.

I understand there is some logic for browser active/deactive state, but when always having the chat open on a monitor the label can become a bit annoying.

@cwc
cwc commented

Sounds like a good preference option. I also leave the window open most of the time, but like having the notification to remind me to glance over and catch up.

@eirikb

This is a completely different feature, but:

Having an unread-notification-line indicating last read message could give the same visual aid, but in a more subtle way). Something like this:
subway-indication-line
I'm not sure if this is already a feature, but at least I can't see it in my version. If it is not perhaps merging this issue and creating a new issue for such a feature is an idea?

@cwc
cwc commented

:+1: the line. Would make it much easier to find where the unread messages begin.

@thedjpetersen thedjpetersen merged commit 9d5aaba into thedjpetersen:024_release
@thedjpetersen

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 21, 2013
  1. @eirikb
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  assets/js/views/channel_tab.js
View
2  assets/js/views/channel_tab.js
@@ -34,6 +34,8 @@ var ChannelTabView = Backbone.View.extend({
var unread = this.model.get('unread');
var unreadMentions = this.model.get('unreadMentions');
+ if ($(this.el).hasClass('active')) return;
+
// TODO: do something more sensible here than remove/readd elements
// this.$el.children('.unread, .unread_mentions').remove();
Something went wrong with that request. Please try again.