Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't show unread-label on open (active) channel/chat #203

Merged
merged 1 commit into from Feb 4, 2013

Conversation

Projects
None yet
3 participants
Contributor

eirikb commented Jan 21, 2013

Suggestion: Don't show the label for unread messages on incoming messages to an already open chat.
I understand there is some logic for browser active/deactive state, but when always having the chat open on a monitor the label can become a bit annoying.

Contributor

cwc commented Feb 1, 2013

Sounds like a good preference option. I also leave the window open most of the time, but like having the notification to remind me to glance over and catch up.

Contributor

eirikb commented Feb 1, 2013

This is a completely different feature, but:
Having an unread-notification-line indicating last read message could give the same visual aid, but in a more subtle way). Something like this:
subway-indication-line
I'm not sure if this is already a feature, but at least I can't see it in my version. If it is not perhaps merging this issue and creating a new issue for such a feature is an idea?

Contributor

cwc commented Feb 1, 2013

👍 the line. Would make it much easier to find where the unread messages begin.

Contributor

eirikb commented Feb 1, 2013

thedjpetersen added a commit that referenced this pull request Feb 4, 2013

Merge pull request #203 from eirikb/unread-suggestion
Don't show unread-label on open (active) channel/chat

@thedjpetersen thedjpetersen merged commit 9d5aaba into thedjpetersen:024_release Feb 4, 2013

Owner

thedjpetersen commented Feb 4, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment