Changed desktop notifications to support Firefox. #291

Merged
merged 1 commit into from Feb 16, 2014

Conversation

Projects
None yet
2 participants
@totokaka
Contributor

totokaka commented Feb 14, 2014

Pretty much everything of the notification handling was redone.
This is tested on Chromium version '32.0.1700.107 (248368)' and
Firefox version 29 and 27 under linux. More testing would be nice.

PS: This is pretty much my first ever work in JavaScript. I hope what I've written is good code, and I'm open to constructive criticism.

Changed desktop notifications to support Firefox.
Pretty much everything of the notification handling was redone.
This is tested on Chromium version '32.0.1700.107 (248368)' and
Firefox version 29 and 27 under linux. More testing would be nice.

thedjpetersen added a commit that referenced this pull request Feb 16, 2014

Merge pull request #291 from totokaka/desktop-notifications
Changed desktop notifications to support Firefox.

@thedjpetersen thedjpetersen merged commit f29aa5f into thedjpetersen:master Feb 16, 2014

@totokaka totokaka deleted the totokaka:desktop-notifications branch Feb 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment