Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

optionally connect to irc with ssl #97

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Adds ssl checkbox and port text box for specifying connecting via ssl and on a specific port.

Defaults to ssl off, port defaults to 6667. If ssl is specified and port is not it defaults to port 6697.

For it to work with oftc martynsmith/node-irc#79 needs to be merged.

@tjfontaine tjfontaine referenced this pull request Mar 19, 2012

Closed

irc ssl support #96

Contributor

akavlie commented Mar 24, 2012

Thanks for working on this. Just tried it out locally, it seems to work just fine. No clues about the SSL status in the app or logs though... it would help if we added something.

One issue I have, that should be rectified before we merge this into master: the UI has a blank input for the port, implying that the field requires input... there's no hint that it will supply the correct port if you leave it blank. I'd like to see that change so the port is pre-filled (and switches automatically when you check/uncheck SSL).

Another request: I think the port input and SSL checkbox should be combined onto the same line in the UI, as the port field doesn't need that much space. Should be easy with .form-inline: http://twitter.github.com/bootstrap/base-css.html#forms

ok I'll do these fix ups and update the pull

why default to to off?

Owner

thedjpetersen commented Apr 12, 2012

@tjfontaine did you update the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment