About: show real TheengsDecoder version and store build number#139
Merged
Conversation
- Derive the bundled TheengsDecoder version from the submodule's git tag
at CMake configure time (fallback literal "2.3.0" for shallow CI clones
and tarball builds). Inject it as THEENGS_DECODER_VERSION on both the
Theengs executable target and the AppUtils static lib so utils_app.cpp
picks it up at compile time.
- Add utilsApp.theengsDecoderVersion() and utilsApp.appBuildNumber():
- Decoder version: replaces the hardcoded "2.1.0" badge and release URL.
- Build number: reads CFBundleVersion on iOS, PackageInfo.versionCode on
Android via JNI, empty on desktop. Matches what users see on the App
Store / Play Store.
- About.qml: header line shows "1.5.0 (<build-number>) DEBUG" on mobile and
drops the build number on desktop where it doesn't apply. The
"Theengs App" badge now binds to appVersion(); the "Theengs Decoder"
badge + GitHub release URL bind to theengsDecoderVersion(). Dependency
list and debug-info section also pick up the new values. Fixes the
decoder license string to GPL v3.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The CMakeLists.txt was carrying a literal "2.3.0" fallback for the THEENGS_DECODER_VERSION macro, which had to be hand-bumped every time the submodule moved — exactly the kind of drift the dynamic git-describe was introduced to prevent. - Remove the literal default. If git describe fails (no .git, etc.), the variable stays empty and the compile-definition is skipped, so utilsApp.theengsDecoderVersion() returns "unknown" — the same behavior AppUtils already exhibits when consumed outside Theengs. - Add fetch-depth: 0 to all five actions/checkout blocks in builds_desktop.yml (3) and builds_mobile.yml (2) so the submodule's tags are available during the CI build. submodules: recursive alone fetches a shallow tree without tags. Tarball/sdist consumers (which Theengs doesn't ship as a release artifact anyway) get "unknown" — acceptable for that out-of-band case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1technophile
added a commit
that referenced
this pull request
Jun 6, 2026
Bump the 1.5.0 release date to 2026-06-06 and fold in the user-facing changes that landed between #130 and the cut: TheengsDecoder v2.3.0 (#137), MQTT sentinels + sampling caption (#131), credential secure storage (#132), background-update scheduling and consolidated permissions UI (#133, #135), the About-screen decoder version and build number (#139), the iOS mbedTLS static-link fix (#138), and the device_bm26 ENABLE_MBEDTLS guard (#134). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
1technophile
added a commit
that referenced
this pull request
Jun 6, 2026
Bump the 1.5.0 release date to 2026-06-06 and fold in the user-facing changes that landed between #130 and the cut: TheengsDecoder v2.3.0 (#137), MQTT sentinels + sampling caption (#131), credential secure storage (#132), background-update scheduling and consolidated permissions UI (#133, #135), the About-screen decoder version and build number (#139), the iOS mbedTLS static-link fix (#138), and the device_bm26 ENABLE_MBEDTLS guard (#134). Co-authored-by: Florian <1technophile@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist: