Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Ansible guide #1755

Merged
merged 1 commit into from Nov 9, 2022
Merged

Rename Ansible guide #1755

merged 1 commit into from Nov 9, 2022

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Nov 3, 2022 •
edited

Configuring and using Ansible integration to configure hosts in Project is analogic to the Puppet integration.
I suggest modifying the title of the guide to make it more obvious.

Please cherry-pick my commits into:

  • Foreman 3.4/Katello 4.6
  • Foreman 3.3/Katello 4.5
  • Foreman 3.2/Katello 4.4
  • Foreman 3.1/Katello 4.3

@Lennonka Lennonka marked this pull request as draft November 3, 2022 13:53
@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited

The PR preview for cc7f661 is available at theforeman-foreman-documentation-preview-pr-1755.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka marked this pull request as ready for review November 8, 2022 17:00
@Lennonka
Copy link
Contributor Author

Lennonka commented Nov 8, 2022

@ares Yay or nay? :)

maximiliankolb
maximiliankolb approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

guides/doc-Managing_Configurations_Ansible/docinfo.xml Show resolved Hide resolved
@Lennonka
Copy link
Contributor Author

Lennonka commented Nov 9, 2022

No protests, I'm merging this. :)

@Lennonka Lennonka merged commit b2acc85 into theforeman:master Nov 9, 2022
9 checks passed
@Lennonka
Copy link
Contributor Author

Lennonka commented Nov 9, 2022

Cherry-picked:

@ekohl
Copy link
Member

ekohl commented Nov 10, 2022

When renaming a guide, please also open a PR to purge the old content from the gh-pages branch. Otherwise users may consume outdated information. Ideally speaking we'd have a redirect, but for now we can live with a 404.

@maximiliankolb
Copy link
Contributor

When renaming a guide, please also open a PR to purge the old content from the gh-pages branch. Otherwise users may consume outdated information. Ideally speaking we'd have a redirect, but for now we can live with a 404.

cc @Lennonka

Yes, but a user experience point of view, we should definitely do this!

Is this as simple as branching gh-pages and running "git rm -r SOME DIRECTORY"?

@ekohl
Copy link
Member

ekohl commented Nov 10, 2022

Yes, it's pretty much that.

@Lennonka Lennonka mentioned this pull request Nov 14, 2022
Merged
1 task
@Lennonka Lennonka deleted the retitle-ansible-guide branch March 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lennonka @ekohl @maximiliankolb