Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name of REX setting #1984

Merged
merged 1 commit into from Feb 9, 2023
Merged

Update name of REX setting #1984

merged 1 commit into from Feb 9, 2023

Conversation

adamlazik1
Copy link
Contributor

@adamlazik1 adamlazik1 commented Feb 9, 2023 •
edited

The remote_execution_prefer_registered_through_proxy cannot be found in Administer > Settings, this setting is in fact Prefer registered through {SmartProxy} for remote execution.

BZ link

Please cherry-pick my commits into:

  • Foreman 3.5/Katello 4.7 (planned Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8, orcharhino 6.1 on EL7, orcharhino 6.2 on EL7/8)
  • For Foreman 3.0 or older, please create a separate PR.
  • We do not accept PRs for Foreman 2.3 or older.

@adamlazik1
Update name of REX setting
395659c 
The `remote_execution_prefer_registered_through_proxy` cannot  be found
in Administer > Setting, this setting is in fact `Prefer registered
through {SmartProxy} for remote execution`.
@adamlazik1
Copy link
Contributor Author

CC @adamruzicka

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

The PR preview for 395659c could not be generated

@adamlazik1
Copy link
Contributor Author

Approved by SME.

maximiliankolb
maximiliankolb approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamlazik1 adamlazik1 merged commit 5b70a48 into theforeman:master Feb 9, 2023
8 of 9 checks passed
@adamlazik1
Copy link
Contributor Author

Merged and cherry-picked:
7302e8d..3a36992 3.1 -> 3.1
fd9207b..79bf6a9 3.2 -> 3.2
fb899e2..8f7d76c 3.3 -> 3.3
b21510d..b034aae 3.4 -> 3.4
14f296d..a21147a 3.5 -> 3.5

@adamlazik1 adamlazik1 deleted the remote-execution-workflow branch February 9, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamlazik1 @maximiliankolb