Move Content Host Registration port from 8443 to 443 #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 18fa78a is available at theforeman-foreman-documentation-preview-pr-2008.surge.sh The following output files are affected by this PR: |
adamlazik1
reviewed
Feb 22, 2023
There was a problem hiding this comment.
I feel like this would be the best to get reviewed by @evgeni
evgeni
reviewed
Mar 28, 2023
mjivraja
force-pushed
the
15570-Port-8443-remove-master
branch
from
a86c75c
to
84a1bf6
Compare
evgeni
approved these changes
Mar 29, 2023
I will amend 👍 |
Remove the port 8443 because it is no longer used by any services on the Project Server itself, even for establishing an incoming connection. Use the 443 port instead for Content Host Registration as the features are still functional over the same port. https://bugzilla.redhat.com/show_bug.cgi?id=2166014
mjivraja
force-pushed
the
15570-Port-8443-remove-master
branch
from
84a1bf6
to
18fa78a
Compare
mjivraja
changed the title
7 tasks
Here we go #2106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove port 8443 because it is no longer used by any services on the Project Server itself, even for establishing an incoming connection. Use the 443 port instead for Content Host Registration as the features are still functional over the same port.
https://bugzilla.redhat.com/show_bug.cgi?id=2166014
Please cherry-pick my commits into: