Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide various links for orcharhino builds #2038

Merged
merged 10 commits into from Mar 15, 2023
Merged

Hide various links for orcharhino builds #2038

merged 10 commits into from Mar 15, 2023

Conversation

maximiliankolb
Copy link
Contributor

Please review commit by commit.

Please cherry-pick my commits into:

  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (planned Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only)

@github-actions
Copy link

github-actions bot commented Mar 3, 2023 •
edited

The PR preview for 6fbca5d is available at theforeman-foreman-documentation-preview-pr-2038.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

adamlazik1
adamlazik1 reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one nitpick.

guides/common/modules/proc_registering-hosts.adoc Outdated Show resolved Hide resolved
@maximiliankolb
Copy link
Contributor Author

Applied all feedback; ready for re-review.

@maximiliankolb
Copy link
Contributor Author

Rebased to master and added one more commit on top. Please re-review.

@maximiliankolb
Copy link
Contributor Author

@adamlazik1 Is this OK for you?

adamlazik1
adamlazik1 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! Thank you!

@maximiliankolb maximiliankolb merged commit 59da6e4 into theforeman:master Mar 15, 2023
9 checks passed
@maximiliankolb maximiliankolb deleted the orcharhino_only branch March 15, 2023 13:36
@maximiliankolb
Copy link
Contributor Author

Merged to master and cherry-picked: ✔️
704a3c2..9e26439 3.6 -> 3.6
6f25b5b..1beff0a 3.5 -> 3.5
847f4e7..92dcdc4 3.4 -> 3.4
465dc2f..32d4649 3.3 -> 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni left review comments

@ekohl ekohl ekohl approved these changes

@adamlazik1 adamlazik1 adamlazik1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maximiliankolb @evgeni @ekohl @adamlazik1