New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Updating Guide #2233
Split Updating Guide #2233
Conversation
|
The PR preview for 9c05232 could not be generated |
db2fd96
to
7feed34
Compare
|
Is it a good idea to add a new guide to older versions? I'd add it just to Satellite 6.14. I don't think it's a good idea to make larger restructuring mid-flight, it could confuse current users. |
Yes, I agree with this view. We can start even start with 6.13 considering the BZs of the same at present. |
6b187aa
to
66cf950
Compare
66cf950
to
8ba8082
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more ideas.
8ba8082
to
dbfdc7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more things. We have a broken build due to a non-existing link. Rebase after #2262 is merged.
|
Please, rebase. |
|
I've updated the cherry-pick list to cp only to 3.7. |
3a0b5c0
to
74be3f9
Compare
|
We may require some work from the upstream repo side. |
@mjivraja What exactly? |
@ehelms In that case, the recommendation is in order, isn't it? :) |
eec27dd
to
d26dc27
Compare
guides/common/modules/con_updating-project-to-next-minor-version.adoc
Outdated
Show resolved
Hide resolved
d26dc27
to
28d98ce
Compare
28d98ce
to
f3bab46
Compare
f3bab46
to
c53f126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more suggestions.
Also:
- I'm wondering if the backup should be the first step in procedures instead of a prerequisite.
- I'm missing a restore step at the end of each procedure.
- In examples, the values that are to be replaced by the user should be formatted as such, i.e.
_replaceable value_.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rename this file to snip_steps-needs-reboot.adoc.
We should give a hint in the name what kind of content the snip has (steps or prerequisite or other).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ./guides/doc-Upgrading_Project/topics/snip_needs_reboot.adoc. I would expect something that moves it from the topic to the common modules instead of duplicating it. I'd do that as a separate PR that we merge before this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack your view on this @ekohl
I have renamed it as of now and it is present at both places including common/modules. I was expecting the Upgrading Guide to be at common/modules but not sure if it is considered in upcoming PRs. This will bring snip_steps-needs-reboot.adoc to common/modules eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ./guides/doc-Upgrading_Project/topics/snip_needs_reboot.adoc. I would expect something that moves it from the topic to the common modules instead of duplicating it. I'd do that as a separate PR that we merge before this one.
c53f126
to
aa26c5b
Compare
@Lennonka I discussed this with |
@mjivraja What are you talking about? |
This is an outdated one. I will stick to the original plan we discussed on Monday. |
9cac865
to
08f47a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details, details, details... :)
035d399
to
4c175a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion and we're good to merge!
We need to split the updating guide from the Upgrading and Updating Guide. I have kept this limited to Downstream only at this level but definitely we can raise the scope to other builds. This may contain the technical modifications, general modifications and at modular level so, please don't hesitate to provide your even minor feedback.
4c175a5
to
9c05232
Compare
Thank you @maximiliankolb for pointing out. Here we go #2374 CC: @AkshayGadhaveRH |
We need to split the updating guide from the Upgrading and Updating Guide. I have kept this limited to Downstream only at this level but definitely we can raise the scope to other builds. This may contain technical modifications, general modifications, and at a modular level so, please don't hesitate to provide even minor feedback.
Please NOTE that this PR only focuses on Updating Guide and not the Upgrading Guide. It will have another PR from @AkshayGadhaveRH. So, please be cautious if you are merging this PR first.
Please cherry-pick my commits into: