Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Updating Guide #2233

Merged

Conversation

mjivraja
Copy link
Contributor

@mjivraja mjivraja commented Jun 14, 2023

We need to split the updating guide from the Upgrading and Updating Guide. I have kept this limited to Downstream only at this level but definitely we can raise the scope to other builds. This may contain technical modifications, general modifications, and at a modular level so, please don't hesitate to provide even minor feedback.

Please NOTE that this PR only focuses on Updating Guide and not the Upgrading Guide. It will have another PR from @AkshayGadhaveRH. So, please be cautious if you are merging this PR first.

Please cherry-pick my commits into:

  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • For Foreman 3.0 or older, please create a separate PR.
  • We do not accept PRs for Foreman 2.4 or older.

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

The PR preview for 9c05232 could not be generated

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from db2fd96 to 7feed34 Compare June 14, 2023 12:58
guides/doc-Updating_Server/docinfo.xml Outdated Show resolved Hide resolved
guides/doc-Updating_Server/master.adoc Outdated Show resolved Hide resolved
@Lennonka
Copy link
Contributor

Is it a good idea to add a new guide to older versions? I'd add it just to Satellite 6.14. I don't think it's a good idea to make larger restructuring mid-flight, it could confuse current users.

@mjivraja
Copy link
Contributor Author

Is it a good idea to add a new guide to older versions? I'd add it just to Satellite 6.14. I don't think it's a good idea to make larger restructuring mid-flight, it could confuse current users.

Yes, I agree with this view. We can start even start with 6.13 considering the BZs of the same at present.

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 6b187aa to 66cf950 Compare June 20, 2023 11:59
@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 66cf950 to 8ba8082 Compare June 21, 2023 12:02
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more ideas.

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 8ba8082 to dbfdc7a Compare June 27, 2023 10:53
@mjivraja mjivraja requested a review from Lennonka June 27, 2023 10:55
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things. We have a broken build due to a non-existing link. Rebase after #2262 is merged.

@Lennonka Lennonka requested review from ekohl and Griffin-Sullivan and removed request for Griffin-Sullivan June 27, 2023 15:39
@Lennonka
Copy link
Contributor

Please, rebase.

@Lennonka
Copy link
Contributor

I've updated the cherry-pick list to cp only to 3.7.

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch 2 times, most recently from 3a0b5c0 to 74be3f9 Compare June 28, 2023 15:25
@mjivraja
Copy link
Contributor Author

We may require some work from the upstream repo side.

@Lennonka
Copy link
Contributor

We may require some work from the upstream repo side.

@mjivraja What exactly?

@Lennonka
Copy link
Contributor

Lennonka commented Jul 31, 2023

They should update every release we put out :)

@ehelms In that case, the recommendation is in order, isn't it? :)

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from eec27dd to d26dc27 Compare August 1, 2023 05:06
@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 28d98ce to f3bab46 Compare August 3, 2023 06:47
@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from f3bab46 to c53f126 Compare August 8, 2023 04:59
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more suggestions.
Also:

  • I'm wondering if the backup should be the first step in procedures instead of a prerequisite.
  • I'm missing a restore step at the end of each procedure.
  • In examples, the values that are to be replaced by the user should be formatted as such, i.e. _replaceable value_.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rename this file to snip_steps-needs-reboot.adoc.

We should give a hint in the name what kind of content the snip has (steps or prerequisite or other).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ./guides/doc-Upgrading_Project/topics/snip_needs_reboot.adoc. I would expect something that moves it from the topic to the common modules instead of duplicating it. I'd do that as a separate PR that we merge before this one.

Copy link
Contributor Author

@mjivraja mjivraja Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack your view on this @ekohl

I have renamed it as of now and it is present at both places including common/modules. I was expecting the Upgrading Guide to be at common/modules but not sure if it is considered in upcoming PRs. This will bring snip_steps-needs-reboot.adoc to common/modules eventually.

guides/common/modules/proc_updating-smart-proxy.adoc Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ./guides/doc-Upgrading_Project/topics/snip_needs_reboot.adoc. I would expect something that moves it from the topic to the common modules instead of duplicating it. I'd do that as a separate PR that we merge before this one.

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from c53f126 to aa26c5b Compare August 9, 2023 14:18
@mjivraja
Copy link
Contributor Author

  • I'm missing a restore step at the end of each procedure.

@Lennonka I discussed this with platform team and we can draft this procedure. Can we consider this for the next PR?

@Lennonka
Copy link
Contributor

  • I'm missing a restore step at the end of each procedure.

@Lennonka I discussed this with platform team and we can draft this procedure. Can we consider this for the next PR?

@mjivraja What are you talking about?
The procedure already exists in the Admin guide. Just mention a link to it the same way as with the backup step.

@mjivraja
Copy link
Contributor Author

@mjivraja What are you talking about? The procedure already exists in the Admin guide. Just mention a link to it the same way as with the backup step.

This is an outdated one. I will stick to the original plan we discussed on Monday.

@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 9cac865 to 08f47a7 Compare August 16, 2023 13:09
@mjivraja mjivraja requested a review from Lennonka August 16, 2023 13:14
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details, details, details... :)

guides/common/modules/proc_updating-server.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_updating-smart-proxy.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_updating-server.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_updating-server.adoc Outdated Show resolved Hide resolved
@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 035d399 to 4c175a5 Compare August 17, 2023 06:30
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion and we're good to merge!

guides/common/modules/snip_using_installer_noop.adoc Outdated Show resolved Hide resolved
guides/common/modules/snip_using_installer_noop.adoc Outdated Show resolved Hide resolved
We need to split the updating guide from the Upgrading and Updating Guide. I have kept this limited to Downstream only at this level but definitely we can raise the scope to other builds. This may contain the technical modifications, general modifications and at modular level so, please don't hesitate to provide your even minor feedback.
@mjivraja mjivraja force-pushed the 17950-Separate-Updating-Guide-master branch from 4c175a5 to 9c05232 Compare August 17, 2023 16:26
@Lennonka Lennonka merged commit ec4aea3 into theforeman:master Aug 17, 2023
8 of 9 checks passed
@Lennonka
Copy link
Contributor

Cherry-picked:

@maximiliankolb
Copy link
Contributor

I believe the guide is still missing in the navigation on docs.theforeman.org. This is how I've added "Configuring hosts using Salt": 1bf2a4f

cc @mjivraja

@mjivraja
Copy link
Contributor Author

I believe the guide is still missing in the navigation on docs.theforeman.org. This is how I've added "Configuring hosts using Salt": 1bf2a4f

cc @mjivraja

Thank you @maximiliankolb for pointing out. Here we go #2374
I have also tried adding Upgrading_Project

CC: @AkshayGadhaveRH

@mjivraja mjivraja deleted the 17950-Separate-Updating-Guide-master branch August 18, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants