Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that hostname needs to be FQDN for Kerberos #594

Merged
merged 1 commit into from Jul 12, 2021

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 9, 2021

Cherry-pick into:

  • Foreman 2.5 (Satellite 6.10)
  • Foreman 2.4
  • Foreman 2.3 (Satellite 6.9)
  • Foreman 2.1 (Satellite 6.8)

Comment on lines 80 to 81
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, this is not specific to Debian, but EL by default does have the hostname as FQDN, while Debian does not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps not everyone will understand this?

Suggested change
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN:
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN (including the domain):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "… FQDN (not only the short name)"? Feels weird to "duplicate" "domain".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we spell out FQDN perhaps?

Suggested change
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN:
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to a Fully Qualified Domain Name. This means the short name is insufficient:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other snippets in the docs, I think I'd go with this:

Suggested change
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN:
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the fully qualified domain name (FQDN), the short name is not sufficient:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, if you change the comma after FQDN to a semicolon, it is perfect.

Copy link
Member

@melcorr melcorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evgeni !

{foreman-example-com}
----
+
Otherwise the installer won't be able to generate the right principal name, needed to join the realm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Otherwise the installer won't be able to generate the right principal name, needed to join the realm.
Otherwise the installer cannot generate the right principal name that is needed to join the realm.

Comment on lines 80 to 81
ifndef::satellite[]
. If {ProjectServer} is running on Debian, ensure that the hostname is set to the FQDN:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, if you change the comma after FQDN to a semicolon, it is perfect.

@evgeni
Copy link
Member Author

evgeni commented Jul 12, 2021

Thanks @melcorr!

Updated!

@melcorr melcorr merged commit a163af0 into theforeman:master Jul 12, 2021
@melcorr
Copy link
Member

melcorr commented Jul 12, 2021

Thank you for your contribution!

ianf77 pushed a commit to ianf77/foreman-documentation that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants