This repository has been archived by the owner on May 26, 2020. It is now read-only.
adding lvm with cinder volumes ptable #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marek we may need to work on the assign_partition_table method, let me know what you think about the way I did it. |
|
Related staypuft UI PR is: |
| rtn_ptable = nil | ||
| ptable_names.each do |ptable_name| | ||
| ptable = @foreman.partition_table.first! %Q(name ~ "#{ptable_name}*") | ||
| rtn_ptable = ptable if ptable_names.first == ptable['name'] |
There was a problem hiding this comment.
I'd assign explicit value in if os['family'], if I understand it correctly, rtn_ptable is always the first of ptable_names
if I'm mistaken, could you please elaborate a meaning of rtn_ptable?
There was a problem hiding this comment.
the return value of this method is used to set the ptable for the base host group. so rtn_table is the specific ptable that should be default, ie kickstart default
ares
added a commit
that referenced
this pull request
Jul 11, 2014
adding lvm with cinder volumes ptable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.