Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tfm-build #71

Open
wants to merge 2 commits into
base: master
from
Open

WIP: tfm-build #71

wants to merge 2 commits into from

Conversation

@sharvit
Copy link
Collaborator

sharvit commented Nov 24, 2019

Updated Packages

  • root
  • @theforeman/babel
  • @theforeman/builder
  • @theforeman/env
  • @theforeman/vendor
  • @theforeman/vendor-dev
  • @theforeman/vendor-core

PR Type

  • Bugfix
  • Feature
  • Code style update (whitespace, formatting, missing semicolons, etc.)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other… Please describe:

Description

Still work in progress, the goal is to be able to build foreman.

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fixes open issues?

  • Yes
  • No

Do you use this PR in another repository?

@@ -0,0 +1,28 @@
const MiniCssExtractPlugin = require('mini-css-extract-plugin');

const createWebpackRules = mode => [

This comment has been minimized.

Copy link
@xprazak2

xprazak2 Nov 25, 2019

Contributor

mode is not (yet) used

@xprazak2

This comment has been minimized.

Copy link
Contributor

xprazak2 commented Nov 25, 2019

I am not sure how I would fix this...

builder-err

@sharvit sharvit force-pushed the sharvit:feat/build branch 2 times, most recently from 4b77ccb to d302ca5 Nov 27, 2019
@sharvit sharvit force-pushed the sharvit:feat/build branch from d302ca5 to f62539c Nov 28, 2019
@xprazak2

This comment has been minimized.

Copy link
Contributor

xprazak2 commented Dec 3, 2019

If 'config' is not supplied as arg:

required-config

it could be required or we might fall back to a default version if it makes sense.

@sharvit

This comment has been minimized.

Copy link
Collaborator Author

sharvit commented Dec 3, 2019

Thanks @xprazak2 👍

@sharvit sharvit force-pushed the sharvit:feat/build branch 2 times, most recently from 6e136c4 to 7ea6c0f Dec 5, 2019
@sharvit sharvit force-pushed the sharvit:feat/build branch from 7ea6c0f to f40bc28 Jan 22, 2020
sharvit added 2 commits Dec 6, 2019
adds support for async imports
@sharvit sharvit force-pushed the sharvit:feat/build branch from f40bc28 to 2590fbf Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.