Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20960 - mirror activerecord-session_store in Gemfile #1830

Merged
merged 1 commit into from Sep 29, 2017
Merged

Refs #20960 - mirror activerecord-session_store in Gemfile #1830

merged 1 commit into from Sep 29, 2017

Conversation

mmoll
Copy link

@mmoll mmoll commented Sep 27, 2017

this should be built into:

  • Nightly

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll Sorry, when this was submitted there was no multi_json 1.12 published yet. It's now in http://koji.katello.org/koji/taskinfo?taskID=32724 so it should build. I'll trigger a manual run

@dLobatog
Copy link
Member

dLobatog commented Sep 27, 2017

@mmoll
Copy link
Author

mmoll commented Sep 27, 2017

seems still not to be where it should:

DEBUG util.py:439:  Error: Package: tfm-rubygem-activerecord-session_store-1.1.0-1.el7.noarch (build)
DEBUG util.py:439:             Requires: sclo-ror42-rubygem(multi_json) >= 1.11.2
DEBUG util.py:439:             Installing: sclo-ror42-rubygem-multi_json-1.10.1-3.el7.noarch (build)
DEBUG util.py:439:                 sclo-ror42-rubygem(multi_json) = 1.10.1

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing because it's looking for sclo-ror42-rubygem(multi_json) but it should be looking for tfm-rubygem(multi_json).

http://koji.katello.org/kojifiles/work/tasks/2737/32737/mock_output.log

Can you change the rubygem-activerecord-session_store spec to:

Requires: %{?scl_prefix}rubygem(multi_json) >= 1.11.2
Requires: %{?scl_prefix}rubygem(multi_json) < 2.0

and increase the Release number to:

Release: 2%{?dist}

That would make sure it requires the right dependency.

@mmoll
Copy link
Author

mmoll commented Sep 27, 2017

aw, ok...

@mmoll
Copy link
Author

mmoll commented Sep 27, 2017

This is now only the change to ar-session_store. If this is OK, it seems cherry-picking and building in the tfm SCL is neededm then I can push the change to foreman.spec again here

@dLobatog
Copy link
Member

@mmoll Looks good!

@mmoll
Copy link
Author

mmoll commented Sep 27, 2017

added the foreman.spec change again.

@dLobatog
Copy link
Member

@mmoll It looks like it still has the same problem, Jenkins doesn't know about dependencies so I believe it builds the packages in any random order, best to submit separate package specs separately, sorry 😞 http://koji.katello.org/kojifiles/work/tasks/2877/32877/mock_output.log

@mmoll
Copy link
Author

mmoll commented Sep 27, 2017

these are two commits, so one could cherry-pick the first and build ar-session_store, then I'd re-trigger the test here.

@ehelms
Copy link
Member

ehelms commented Sep 28, 2017

[test]

@mmoll
Copy link
Author

mmoll commented Sep 28, 2017

💚

@mmoll
Copy link
Author

mmoll commented Sep 29, 2017

should be good to go now.

@mmoll mmoll merged commit 877075b into theforeman:rpm/develop Sep 29, 2017
@mmoll mmoll deleted the rpm/develop_ass_fm branch September 29, 2017 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants