Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nodejs-theforeman-vendor to 3.0.0 #4330

Closed
wants to merge 1 commit into from

Conversation

@sharvit

This comment has been minimized.

Copy link
Author

sharvit commented Nov 12, 2019

Any idea what if wrong?

@xprazak2

This comment has been minimized.

Copy link
Contributor

xprazak2 commented Nov 13, 2019

Node packages were moved to scl, but the newer version of npm2rpm that reflects this change has not been released, so it updates your spec for the non-scl version.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Nov 13, 2019

So we've updated npm2rpm to output specs that can work with SCL in order to support a more modern nodejs but currently rely on an unreleased version. If you generate this with the master version, it should work.

Edit: I should have read @xprazak2's comment.

@sharvit sharvit force-pushed the sharvit:rpm/vendor-v3 branch from 17cb60a to 3475f17 Nov 13, 2019
@sharvit

This comment has been minimized.

Copy link
Author

sharvit commented Nov 13, 2019

Thanks @ekohl @xprazak2

I followed @xprazak2 instructions

@sharvit sharvit force-pushed the sharvit:rpm/vendor-v3 branch from 3475f17 to 76fc054 Nov 13, 2019
@sharvit

This comment has been minimized.

Copy link
Author

sharvit commented Nov 13, 2019

It's green :)

@tbrisker

This comment has been minimized.

Copy link
Member

tbrisker commented Nov 19, 2019

should this be closed in favor of #4348 or update to get 3.1?

@sharvit

This comment has been minimized.

Copy link
Author

sharvit commented Nov 19, 2019

Yes @tbrisker thanks, closing.

@sharvit sharvit closed this Nov 19, 2019
@sharvit sharvit deleted the sharvit:rpm/vendor-v3 branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.