Fixes #8710 - introduced foreman-debug subpackage #490
Conversation
|
Yeah, that's OK. Can you do the same for the debs? |
|
plus a comps update |
|
Sure, I was thinking to require this package by foreman-proxy. What do you think? Also as my next step, I want to add foreman-proxy support (files which are only on proxy + underlaying services). |
|
I guess that's OK - the dependency seems slightly strange, but I can't think of a reason why it'd be a problem. |
lzap
force-pushed
the
foreman-debug-sub-8710
branch
from
8e3b57d
to
c2be240
Compare
|
Pushed the comps as well as proxy part. Foreman: http://koji.katello.org/koji/taskinfo?taskID=218303 |
lzap
force-pushed
the
foreman-debug-sub-8710
branch
from
c2be240
to
2ec8653
Compare
|
foreman & smart-proxy pieces are now merged |
| @@ -184,6 +188,7 @@ rm -rf %{buildroot} | |||
| %{_unitdir}/%{name}.service | |||
| %{_prefix}/lib/tmpfiles.d/%{name}.conf | |||
| %endif | |||
| /usr/share/foreman/script/foreman-debug.d/75-foreman-proxy | |||
lzap
force-pushed
the
foreman-debug-sub-8710
branch
from
2ec8653
to
e09763d
Compare
|
All fixed sorry for the delay. http://koji.katello.org/koji/taskinfo?taskID=220938 |
|
Is there anything else than this PR that blocks the branching/release? |
|
@lzap this PR and we need an equivalent for deb/develop |
| @@ -559,6 +573,8 @@ rm -rf %{buildroot} | |||
| %dir %{_datadir}/%{name} | |||
| %{_datadir}/%{name}/app | |||
| %exclude %{_datadir}/%{name}/app/assets | |||
| %exclude %{_datadir}/%{name}/bundler.d/* | |||
There was a problem hiding this comment.
remove this line, not required
|
Do you have a scratch build of foreman-proxy too please? |
lzap
force-pushed
the
foreman-debug-sub-8710
branch
from
e09763d
to
7d10d30
Compare
|
Hmm it failed. |
|
Gimme a min to rebuild. |
|
http://koji.katello.org/koji/taskinfo?taskID=220999 foreman-proxy @GregSutcliffe can you provide me a guidiance of similar change for debian please? I have zero idea how to do that. |
| @@ -196,6 +199,17 @@ Meta Package to install hammer rubygems and its dependencies | |||
|
|
|||
| %files cli | |||
|
|
|||
| %package debug | |||
There was a problem hiding this comment.
There's a requires in 'foreman' for rsync, could you move it to the debug package please, as it's used by foreman-debug.
lzap
force-pushed
the
foreman-debug-sub-8710
branch
from
7d10d30
to
b79e046
Compare
|
Fixed. Debian package is on my radar, although I'd appreciate guidiance from @GregSutcliffe. I've never created a subpackage in Debian... http://www.doudoulinux.org/web/english/contribute/developers/working-within-debian/article/splitting-a-debian-package.html |
Fixes #8710 - introduced foreman-debug subpackage
|
Thanks @lzap! Sure, there are a few of us who I'm sure would be happy to help or maybe even do it. (Michael, Tomas, Greg and myself for instance.) |
|
I think I can handle it. Thanks. |
Is this kosher?