Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-pulp_deb_client to 2.9.1 for Katello 4.0 #6587

Merged
merged 1 commit into from May 4, 2021

Conversation

quba42
Copy link

@quba42 quba42 commented Apr 30, 2021

No description provided.

@quba42 quba42 changed the title Update rubygem-pulp_deb_client to 2.9.1 Update rubygem-pulp_deb_client to 2.9 Apr 30, 2021
@quba42 quba42 changed the title Update rubygem-pulp_deb_client to 2.9 Update rubygem-pulp_deb_client to 2.9.1 Apr 30, 2021
@quba42
Copy link
Author

quba42 commented Apr 30, 2021

Since the Katello rubygem change has now been merged, this WILL be required for the Katello 4.0.1 release.
Beyond that I have no opinion on when it should be merged.

@quba42 quba42 marked this pull request as ready for review April 30, 2021 16:44
@quba42 quba42 changed the title Update rubygem-pulp_deb_client to 2.9.1 Update rubygem-pulp_deb_client to 2.9.1 for Katello 4.0 May 3, 2021
@theforeman-bot theforeman-bot added the Stable branch PRs that are opened against a stable branch. Usually a cherry pick label May 3, 2021
@quba42
Copy link
Author

quba42 commented May 3, 2021

Note: this PR is still missing the corresponding dependency changes here:

Requires: %{?scl_prefix}rubygem(pulp_deb_client) >= 2.6.0

(and three other lines from the same file).

I am not sure if I need to add those changes to this PR, or if that will be done by automation, since it is already part of: https://github.com/Katello/katello/blob/3830e03ef264933469c7b7c8e637b77da53a26ac/katello.gemspec#L59

@jlsherrill
Copy link

[test rpm]

@jlsherrill jlsherrill merged commit 99ca5d6 into theforeman:rpm/2.4 May 4, 2021
@quba42 quba42 deleted the pulp_deb_client_for_2.4 branch May 4, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
3 participants