Fixes #11674 - Bookmarks for task states #133
Conversation
| @@ -0,0 +1,25 @@ | |||
| class AddForemanTasksBookmarks < ActiveRecord::Migration | |||
| def up | |||
| Bookmark.where(:name => "pending", | |||
There was a problem hiding this comment.
I would recude the number of different bookmarks: this states often don't tell anything to the end user. I would suggest two bookmars:
- running: state = running
- failed: state = paused OR result = error OR result = warning
xprazak2
force-pushed
the
sorting-tasks
branch
from
667f9a2
to
996a03f
Compare
|
Number of bookmarks reduced to 2 and file moved from migrations to seeds.d |
| end | ||
|
|
||
| def down | ||
| Bookmark.where(:controller => "foreman_tasks_tasks").map(&:destroy) |
There was a problem hiding this comment.
This would destroy user-created bookmarks too, are we ok with it?
Wouldn't #each be more suited here, since we don't want to keep the results?
There was a problem hiding this comment.
The seeds are not migrations: so just moving the file to different place is not enough. I guess inspiring more form the way we seed the bookmarks in foreman is the best thing we can do https://github.com/theforeman/foreman/blob/develop/db/seeds.d/15-bookmarks.rb
There was a problem hiding this comment.
Also, it seems and and or operations are somehow preferred over && and ||
xprazak2
force-pushed
the
sorting-tasks
branch
from
996a03f
to
db66cc3
Compare
|
I changed it into the same format as we have in Foreman. |
|
|
||
| ].each do |item| | ||
| next if Bookmark.find_by_name(input[:name]) | ||
| next if audit_modified? Bookmark, input[:name] |
xprazak2
force-pushed
the
sorting-tasks
branch
from
db66cc3
to
6050bf5
Compare
|
Works well, merging! |
Fixes #11674 - Bookmarks for task states
I've added sortable column
ended_atand bookmarks that should point to potentially problematic tasks requiring user's attention.