Fixes #16922 - Clean old tasks automaticaly #278
Conversation
adamruzicka
force-pushed
the
16922_cleanup_cron
branch
from
4c9904b
to
dda2c02
Compare
config/foreman-tasks.yaml.example
Outdated
| @@ -16,11 +16,24 @@ | |||
| :cleanup: | |||
| # | |||
| # the period after which to delete all the tasks (by default all tasks are not being deleted after some period) | |||
| # will be deprecated (TODO: mention when) and the use of rules is recommended | |||
There was a problem hiding this comment.
Whatever comes with Foreman 1.18?
lib/foreman_tasks/cleaner.rb
Outdated
| @@ -11,11 +11,17 @@ def self.run(options) | |||
| end | |||
| end | |||
| if cleanup_settings[:after] | |||
| # TODO: Mention version in which this will be removed completely | |||
| ActiveSupport::Deprecation.warn('You are using legacy interface, please migrate from using :after to cleanup rules') | |||
There was a problem hiding this comment.
Foreman::Deprecation.deprecation_warning("1.18", _(':after setting in tasks cleanup section is deprecated, use :after in :rules section to set the value. to cleanup rules'))
|
Let's rebase this and add some tests before we proceed |
adamruzicka
force-pushed
the
16922_cleanup_cron
branch
from
dda2c02
to
32c6389
Compare
|
The test matrix is all green but the build was marked as failed. Let's try it again [test] |
config/foreman-tasks.yaml.example
Outdated
| - :filter: result = success | ||
| :after: 30d | ||
| # Delete everything (any action, any state) after one year | ||
| - :states: [] |
There was a problem hiding this comment.
I know I just keep adding comments here, but this is the last one (hopefully:). It's not very clear that empty states means all while missing/nil means 'stopped'. What about introducing 'all' as recognized value that would replace the [] optoin we have now.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Looks good, waiting for tests to finish. There is one failure so far, but seems not to be related directly |
|
The tests are done, with one (most likely) unrelated failure. |
|
Thanks @adamruzicka and @mbacovsky |
This PR includes #247. Based on discussion in original PR this now also allows to distinguish between green an red (and any other) tasks and set different cleanup intervals.